search

openfun / cunningham

🎨 The Open FUN Design System
https://openfun.github.io/cunningham/
MIT License
23 stars 2 forks source link

✨(react) add enableSorting support on DataGrid #299

Closed NathanVss closed 8 months ago

NathanVss commented 8 months ago

Previously it was only available at column level. This way we will be able to disable sorting on all columns at once.

changeset-bot[bot] commented 8 months ago

🦋 Changeset detected

Latest commit: aac01d7b2c3ca39d739f234d81caabb6b1d12fe6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------------- | ----- | | @openfun/cunningham-react | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

lebaudantoine commented 8 months ago

Yeaaah omg you ship it so fast 🤩 Small question, should we refactor this line to disable sorting at table level instead of setting it for each column? Wdyt? My suggestion might not be appropriate

NathanVss commented 8 months ago

Yeaaah omg you ship it so fast 🤩 Small question, should we refactor this line to disable sorting at table level instead of setting it for each column? Wdyt? My suggestion might not be appropriate

Yep it's done :)