openfun / fun-apps

:warning: DEPRECATED :warning:
Other
15 stars 20 forks source link

Ficus rebase: Course Dashboard > Remove #602

Closed pomegranited closed 7 years ago

pomegranited commented 7 years ago

Removes functionality from the FUN Course Dashboard which is provided by Ficus Insights.

Screenshots:

Before this change:

Course Dashboard Home: orig - dashboard home

Course Dashboard Demo Course Home: orig - course home

After this change:

Course Dashboard Home: removed - dashboard home

Course Dashboard Demo Course Home: removed - course home

Testing instructions:

  1. Check out this PR's branch under /edx/app/edxapp/fun-apps
  2. Run the lms:
    edxapp@precise64:~/edx-platform$ fun lms.dev run
  3. Run the discussion forum:
    forum@precise64:~/cs_comments_service$ ruby app.rb  -p 18080
  4. Login to the LMS as the admin@example.com user, or a superuser. I'm not sure what the default password for admin@example.com was, but I reset mine using the fun lms.dev shell.
  5. Visit the Course Dashboard home page: http://localhost:8000/courses/fun/dashboard/ Notice that the new home page is the Global Student Map, instead of the removed Global Enrollments page.
  6. Visit the Course Dashboard page for the DemoX course: http://localhost:8000/courses/course-v1:edX+DemoX+Demo_Course/fun/dashboard/ Notice that the new home page is the Course Forum Activity page, instead of the removed Course Enrollments page. Notice that the following links have been removed from the header: Statistiques d'inscriptions, Carte des apprenants, and Répartition des réponses.
  7. Visit the Backoffice home page: http://localhost:8000/backoffice/ Notice that the Statistiques link now directs you to the Global Student Map page, instead of the removed Global Enrollments page.
  8. Visit the course detail page for the Demo course: http://localhost:8000/backoffice/course/course-v1:edX+DemoX+Demo_Course Notice that the Tableau de bord link now directs you to the Course Forum Activity page, instead of the removed Course Enrollments page.
  9. Visit the removed pages, and note the 404 response: http://localhost:8000/courses/fun/dashboard/enrollments/ http://localhost:8000/courses/course-v1:edX+DemoX+Demo_Course/fun/dashboard/enrollments/ http://localhost:8000/courses/course-v1:edX+DemoX+Demo_Course/fun/dashboard/map/ http://localhost:8000/courses/course-v1:edX+DemoX+Demo_Course/fun/dashboard/problem_stats/index/

Author notes and concerns:

The automated testing procedure is currently throwing a number of errors on the base ficus and dev branches:

edxapp@precise64:~/fun-apps$ git status
# On branch ficus
# Your branch is up-to-date with 'origin/ficus'.
#
nothing to commit, working directory clean
edxapp@precise64:~/fun-apps$ fun lms.test test
... 
Ran 318 tests in 59.825s
FAILED (SKIP=21, errors=10, failures=6)

This change removes the tests related to the removed functionality, and so the number of tests run decreases. However, it does not fix these base issues, but we do ensure that no new errors appear.

edxapp@precise64:~/fun-apps$ git status
# On branch jill/ficus-ft-2-course-dashboard-remove
# Your branch is up-to-date with 'opencraft/jill/ficus-ft-2-course-dashboard-remove'.
#
nothing to commit, working directory clean
edxapp@precise64:~/fun-apps$ fun lms.test test
...
Ran 283 tests in 50.823s
FAILED (SKIP=21, errors=10, failures=6)

Reviewers

pomegranited commented 7 years ago

@julAtWork Is it ok for me to merge this to the ficus branch now, so it can be deployed to your server for testing?

Wasn't sure if I need a second 👍 from you before merging or not.