openfun / kubic

A Kubernetes deployment as code to OVH or Scaleway, with Prometheus, ArgoCD and Hashicorp Vault
https://openfun.github.io/kubic/
MIT License
37 stars 3 forks source link

🐛 (Argocd Apps): Fix maps instead of lists, pin argocd apps version #118

Closed p-bizouard closed 1 month ago

p-bizouard commented 5 months ago

Fix error on argocd-apps, since the upsream now use maps instead of list for applicationsets:

╷
│ Error: unable to decode "": json: cannot unmarshal number into Go struct field ObjectMeta.metadata.name of type string
│
│   with helm_release.argocd-apps[0],
│   on argocd.tf line 28, in resource "helm_release" "argocd-apps":
│   28: resource "helm_release" "argocd-apps" {

See https://github.com/argoproj/argo-helm/commit/237493a4ab1478a0c33cb1253767f65ce4ec007c

Pin argocd apps version to terraform.tfvars

revolunet commented 1 month ago

this looks useful

p-bizouard commented 1 month ago

@claudusd Hi, I set a backward compatible version on argocd_apps_version so it should not break existing clusters, and allow compatibility with argocd apps v2+