Closed tschaub closed 5 months ago
update the test_data files to include the right version
Did they go out in 1.1.0 with the wrong version? Or are you saying they'd get 1.1.0+p1 as the version?
Did they go out in 1.1.0 with the wrong version? Or are you saying they'd get 1.1.0+p1 as the version?
I was unsure if they were updated as part of the previous release to include the new dev version (1.2.0-dev
, like with the other example data).
I see now that the test_data
is generated with a new script that has yet another version of the version identifier in it. This means that the test_data
will not get updated unless we update the release process to describe how to do that.
As part of https://github.com/opengeospatial/geoparquet/issues/232 I think it would make sense to make it so the test data is generated with the version number from format-specs/schema.json
- and ideally put in a place with a readme that describes how to install the required dependencies (like the scripts
directory).
Here are the website changes to support build metadata in our release tags: https://github.com/geoparquet/geoparquet.github.io/pull/59 (this may need additional changes after we push this tag)
I've pushed the v1.1.0+p1
tag and created a release.
The website has been updated (see https://github.com/geoparquet/geoparquet.github.io/pull/59) to strip the build metadata when extracting the version from a tag (sorting to get the most recent based on semver).
As mentioned in the release notes, the version to use in the GeoParquet metadata is still 1.1.0
.
The corrected spec is published here (over the old one): https://geoparquet.org/releases/v1.1.0/
Because we didn't delete the old tag, people can still get to the old and new spec via git. Validators and other clients should use the published version of the spec and metadata schema instead.
Thanks @tschaub for streamlining this. Such a workflow with +p1
metadata sounds good to me.
For this PR, there is no longer an actual relevant diff?
For this PR, there is no longer an actual relevant diff?
Yeah, the release branch was useful for making release-related changes, tagging the release, and then changing things back to dev versions. But we could close this without merging now.
This includes fixes to the 1.1.0 release (https://github.com/opengeospatial/geoparquet/pull/234). This is being tagged with build metadata
p1
. After creating this release, the website needs to be updated to host the most recent version of the spec and schema at the "clean" version while considering build metadata.~TODO:~
test_data
files to include the right version~test_data
~