openhab / openhab-addons

Add-ons for openHAB
https://www.openhab.org/
Eclipse Public License 2.0
1.9k stars 3.59k forks source link

[Netatmo] Getting ID:s for Netatmo modules. #13091

Closed mikaelgu80 closed 2 years ago

mikaelgu80 commented 2 years ago

A few improvement ideas for the otherwise awesome new Netatmo binding, or its documentation really. 1) It should be noted, that in order to add devices in the "security" category, one needs to add a home (found out the hard way). 2) while searching for the proper id for home, I landed on https://dev.netatmo.com/apidocumentation/security#homesdata. The ID is listed there, so no problem, but should be mentioned in the docs.

And finally, as that API call lists all devices/modules that have been installed, couldn't they be autodiscovered after succesfully creating the bridge?

lolodomo commented 2 years ago

The discovery is already there. Just launch a manual scan in MainUI. So the best solution to find home ID could be to scan things in MainUI.

Adding a note about the need of a home bridge is a good idea.

mikaelgu80 commented 2 years ago

The discovery is already there. Just launch a manual scan in MainUI.

Totally missed that. Good to know!

VincentPersi commented 2 years ago

I guess I also missed the discovery but I found out the long way that if you want to manually add an additional indoor module, you need to append not 00:00 like for the external one but rather ff:ff

lolodomo commented 2 years ago

We could add a console command to list all the devices/modules with their IDs. It could even show the full hierarchy. We should then reuse the discovery code.

lolodomo commented 2 years ago

I will implement it as I think I have a clear idea of what to do and how to do it properly,

lolodomo commented 2 years ago

The PR is submitted, I think this is very interesting as the console command shows of course the IDs but also all the hierarchy of associated thing types.