search

openhab / openhab-core

Core framework of openHAB
https://www.openhab.org/
Eclipse Public License 2.0
914 stars 422 forks source link

Some addons restart after uninstalling an unrelated addon #1354

Closed 5iver closed 3 years ago

5iver commented 4 years ago

I believe this is a symptom of issues reported in the forum, where zigbee or zwave are no longer working after upgrading to 2.5. Logs show cyclic binding uninstalls, which is what I am seeing too. When uninstalling an addon, there are other addons being stopped and started. Included in these are zigbee and zwave. Zigbee does not behave well to binding restarts and usually requires an OH restart to get it working properly. Zwave handles binding restarts OK, but it is a resource hog and responsiveness in the zwave network will be much reduced. If this happens repeatedly, then I can understand why people think 2.5 is broken.

I was recently looking into the new icalendar binding and needed to remove the 1.x caldav-command to test something. I noticed in the log and figured it was time to report this. I suspect that zwave and zigbee are restarting due to org.openhab.core.config.serial being restarted. Here is the log...

2020-02-04 13:11:54.775 [INFO ] [org.apache.sshd.server.session.ServerUserAuthService] - Session openhab@/127.0.0.1:39180 authenticated
2020-02-04 13:23:53.647 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] - Removing features: openhab-binding-caldav-command1/[1.14.0,1.14.0]
2020-02-04 13:23:55.665 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] - Changes to perform:
2020-02-04 13:23:55.665 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   Region: root
2020-02-04 13:23:55.665 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     Bundles to uninstall:
2020-02-04 13:23:55.665 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -       org.openhab.binding.caldav-command/1.14.0
2020-02-04 13:23:55.666 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] - Stopping bundles:
2020-02-04 13:23:55.666 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.zwave/2.5.2.202001250516
2020-02-04 13:23:57.392 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.zigbee.telegesis/2.5.2.202001250519
2020-02-04 13:23:57.398 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.zigbee.xbee/2.5.2.202001250519
2020-02-04 13:23:57.406 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.zigbee.cc2531/2.5.2.202001250518
2020-02-04 13:23:57.411 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.core.config.serial/2.5.0
2020-02-04 13:23:57.414 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   swagger-jersey2-jaxrs/1.5.8.v20160511-1038
2020-02-04 13:23:57.415 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   reflections/0.9.10.v20160429-1435
2020-02-04 13:23:57.416 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   io.swagger.jaxrs/1.5.8
2020-02-04 13:23:57.417 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   com.eclipsesource.jaxrs.provider.swagger/1.1.1.201605111122
2020-02-04 13:23:57.421 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.caldav-command/1.14.0
2020-02-04 13:23:57.425 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.core.io.transport.serial.rxtx.rfc2217/2.5.0
2020-02-04 13:23:57.429 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.zigbee.ember/2.5.2.202001250519
2020-02-04 13:23:57.720 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.core.io.transport.serial/2.5.0
2020-02-04 13:23:57.731 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.core.io.transport.serial.rxtx/2.5.0
2020-02-04 13:23:57.734 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.zigbee/2.5.2.202001250518
2020-02-04 13:23:57.773 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] - Uninstalling bundles:
2020-02-04 13:23:57.773 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.caldav-command/1.14.0
2020-02-04 13:23:57.780 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] - Refreshing bundles:
2020-02-04 13:23:57.780 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     com.eclipsesource.jaxrs.provider.swagger/1.1.1.201605111122 (Wired to io.swagger.jaxrs/1.5.8 which is being refreshed)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     io.swagger.jaxrs/1.5.8 (Wired to reflections/0.9.10.v20160429-1435 which is being refreshed)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.caldav-command/1.14.0 (Bundle will be uninstalled)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zigbee/2.5.2.202001250518 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zigbee.cc2531/2.5.2.202001250518 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zigbee.ember/2.5.2.202001250519 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zigbee.telegesis/2.5.2.202001250519 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zigbee.xbee/2.5.2.202001250519 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zwave/2.5.2.202001250516 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.core.config.serial/2.5.0 (Should be wired to: org.openhab.core.io.transport.serial/2.5.0 (through [org.openhab.core.config.serial/2.5.0] osgi.wiring.package; filter:="(&(osgi.wiring.package=org.eclipse.smarthome.io.transport.serial)(version>=2.5.0)(!(version>=3.0.0)))"))
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.core.io.transport.serial/2.5.0 (Should be wired to: org.openhab.core.io.transport.serial/2.5.0 (through [org.openhab.core.io.transport.serial/2.5.0] osgi.wiring.package; filter:="(osgi.wiring.package=org.eclipse.smarthome.io.transport.serial)"))
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.core.io.transport.serial.rxtx/2.5.0 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.core.io.transport.serial.rxtx.rfc2217/2.5.0 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.783 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     reflections/0.9.10.v20160429-1435 (Should be wired to: com.google.guava/18.0.0 (through osgi.wiring.package; filter:="(osgi.wiring.package=com.google.common.base)"; resolution:="optional"))
2020-02-04 13:23:57.783 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     swagger-jersey2-jaxrs/1.5.8.v20160511-1038 (Wired to io.swagger.jaxrs/1.5.8 which is being refreshed)
2020-02-04 13:23:58.437 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] - Done.

2020-02-04 13:23:57.417 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   com.eclipsesource.jaxrs.provider.swagger/1.1.1.201605111122
2020-02-04 13:23:57.421 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.caldav-command/1.14.0
2020-02-04 13:23:57.425 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.core.io.transport.serial.rxtx.rfc2217/2.5.0
2020-02-04 13:23:57.429 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.zigbee.ember/2.5.2.202001250519
2020-02-04 13:23:57.720 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.core.io.transport.serial/2.5.0
2020-02-04 13:23:57.731 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.core.io.transport.serial.rxtx/2.5.0
2020-02-04 13:23:57.734 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.zigbee/2.5.2.202001250518
2020-02-04 13:23:57.773 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] - Uninstalling bundles:
2020-02-04 13:23:57.773 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -   org.openhab.binding.caldav-command/1.14.0
2020-02-04 13:23:57.780 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] - Refreshing bundles:
2020-02-04 13:23:57.780 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     com.eclipsesource.jaxrs.provider.swagger/1.1.1.201605111122 (Wired to io.swagger.jaxrs/1.5.8 which is being refreshed)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     io.swagger.jaxrs/1.5.8 (Wired to reflections/0.9.10.v20160429-1435 which is being refreshed)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.caldav-command/1.14.0 (Bundle will be uninstalled)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zigbee/2.5.2.202001250518 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zigbee.cc2531/2.5.2.202001250518 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zigbee.ember/2.5.2.202001250519 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.781 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zigbee.telegesis/2.5.2.202001250519 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zigbee.xbee/2.5.2.202001250519 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.binding.zwave/2.5.2.202001250516 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.core.config.serial/2.5.0 (Should be wired to: org.openhab.core.io.transport.serial/2.5.0 (through [org.openhab.core.config.serial/2.5.0] osgi.wiring.package; filter:="(&(osgi.wiring.package=org.eclipse.smarthome.io.transport.serial)(version>=2.5.0)(!(version>=3.0.0)))"))
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.core.io.transport.serial/2.5.0 (Should be wired to: org.openhab.core.io.transport.serial/2.5.0 (through [org.openhab.core.io.transport.serial/2.5.0] osgi.wiring.package; filter:="(osgi.wiring.package=org.eclipse.smarthome.io.transport.serial)"))
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.core.io.transport.serial.rxtx/2.5.0 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.782 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     org.openhab.core.io.transport.serial.rxtx.rfc2217/2.5.0 (Wired to org.openhab.core.io.transport.serial/2.5.0 which is being refreshed)
2020-02-04 13:23:57.783 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     reflections/0.9.10.v20160429-1435 (Should be wired to: com.google.guava/18.0.0 (through osgi.wiring.package; filter:="(osgi.wiring.package=com.google.common.base)"; resolution:="optional"))
2020-02-04 13:23:57.783 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] -     swagger-jersey2-jaxrs/1.5.8.v20160511-1038 (Wired to io.swagger.jaxrs/1.5.8 which is being refreshed)
2020-02-04 13:23:58.437 [INFO ] [org.apache.karaf.features.internal.service.FeaturesServiceImpl] - Done.
mhilbush commented 4 years ago

Interesting, and also possibly the cause of this for bindings that have thing actions.

https://github.com/openhab/openhab-core/issues/1265#issuecomment-580219877

splatch commented 4 years ago

I believe the root cause is here: https://github.com/openhab/openhab-core/issues/1322#issuecomment-576351187

Refreshing bundles where we do use declarative services (as far I know) is not needed..

lolodomo commented 4 years ago

I think I see the same strange beahviour last week when I uninstalled the Freebox binding, meaning other bindings were restarted. I can't say if all or only a part of the other bindings were restarted. This is at least a major bug.

kandersen01 commented 4 years ago

It is a major bug, and critical issue imho.