search

openhab / openhab-docs

This repository contains the documentation for openHAB.
https://www.openhab.org/docs/
Other
274 stars 695 forks source link

[profiles] Update index.md #2367

Closed udo1toni closed 2 months ago

udo1toni commented 2 months ago

For consistency, existing system profiles need keyword system:

netlify[bot] commented 2 months ago

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
Latest commit 393fa978206727a22bf442cef91f2fd0c88e4a39
Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/66f8239063cc9d0008426c2b
Deploy Preview https://deploy-preview-2367--openhab-docs-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jimtng commented 2 months ago

I like not having to type so much and if a plain "follow" works without "system:follow" why not? It was implemented in core to allow it and "forcing" / documenting otherwise would negate that benefit.

udo1toni commented 2 months ago

The point is, it's different in the items documentation: https://www.openhab.org/docs/configuration/items.html#profiles.

So which one is "correct"?

jimtng commented 2 months ago

Just to update my findings here as well (I did write about it on the forums too): core will tolerate it without "system:" but it will log an info message. Maybe we should ask @openhab/core-maintainers about which one is preferred here?

stefan-hoehn commented 2 months ago

@jimtng So the docu change here is fine for you?

jimtng commented 2 months ago

Yes