search

openhab / openhab-ios

The repository of the iOS client
Eclipse Public License 2.0
194 stars 128 forks source link

Support input element in sitemaps. #726

Open mherwege opened 1 year ago

mherwege commented 1 year ago

This is an enhancement request.

With OH4, there is now support for input elements in sitemaps. I have implemented this in BasicUI and the Android App. It would be nice for someone to implement this in the IOS app.

REdelhoff commented 9 months ago

Is there any progress on this feature request? I would also like to be able to enter free text inside the IOS App

TAKeanice commented 6 months ago

The maintainers are currently in the process of recovering their watchId app identifier with Apple and not able to release as far as I know.

Until then, I would like to try and implement that feature. I started on #755 .

nw378 commented 3 weeks ago

Any progress on this issue?

TAKeanice commented 3 weeks ago

I made some, but did not get around to testing it yet and put the task aside for a while. Let me review it this weekend.

nw378 commented 3 weeks ago

Good news, looking forward to...

TAKeanice commented 2 weeks ago

@nw378 I opened the PR #755 for review. Date input is not working yet though.

TAKeanice commented 2 weeks ago

The PR with support for the sitemap input feature is ready to be reviewed. @timbms @mherwege, @REdelhoff and @nw378 I am looking forward to your feedback!

nw378 commented 1 week ago

@TAKeanice sorry, I'm not so familar with PRs. What do I have to do to review it?

TAKeanice commented 1 week ago

No Problem @nw378 , there were already some maintainers that reviewed what I have implemented. It is now included in this repository and will be included in a future release.

timbms commented 1 week ago

TestFlight release 3.0.8(30) is available.

nw378 commented 1 week ago

Yes, just got a notification about the new version. It's working proper, thanks alot @TAKeanice !

nw378 commented 1 week ago

Just tested a bit more @TAKeanice ... Unfortunately, there seems to be a bug:

With more than one item on a site, the input of them interacts accidental.

        Input item=Clock_08 label="Außenleuchten an" icon="clock_dark" inputHint="time" //[JS(numberToClock.js):%s] minValue=0 maxValue=1425 step=15 
        Input item=Clock_09 label="Außenleuchten aus" icon="clock_dark" inputHint="time"

https://github.com/user-attachments/assets/30766056-15a8-4a44-b2de-0228d131b3c3

TAKeanice commented 1 week ago

Just tested a bit more @TAKeanice ... Unfortunately, there seems to be a bug:

Excellent testing! I will check what causes that behavior. For everyone who doesn't recognize it immediately (I also had to watch the video several times): The date picker of one time (morgens Außenleuchten an) gets set to another time that wa previously input for a different item (abends Außenleuchten aus, 7:30). It happens in the last 10s of the video.

nw378 commented 1 week ago

yes, and the date picker itself is also jumping. Hard to explain. you have to try it yourself.

timbms commented 1 week ago

This sounds like a similar problem to #646 addressed by #715.