openhab / openhab1-addons

Add-ons for openHAB 1.x
Eclipse Public License 2.0
3.43k stars 1.69k forks source link

[gcal] PresenceSimulation does not handle event description with start & stop stanzas #4962

Open mhilbush opened 7 years ago

mhilbush commented 7 years ago

[PresenceSimulation] calendar events whose description contains start & stop stanzas are not properly handled. These should be handled similarly to other gcal calendar events with start and stop stanzas (i.e. the start command should be executed at the calendar event start time, and the stop command should be executed at the calendar event stop time).

watou commented 7 years ago

Thanks Mark!

watou commented 7 years ago

Hi Mark, was this considered a bug, user error, or problem with the documentation?

mhilbush commented 7 years ago

I would view it as an enhancement to the existing functionality. Currently, presence simulation expects just a command in the calendar description. This is because the presence simulation commands are added by the gcal persistence service when an item in the presence simulation group executes a command.

The user had manually entered calendar descriptions tagged with [Presence Simulation] that contained start and stop stanzas. These failed to execute because the code expects a command without start/stop stanzas.

watou commented 7 years ago

If this is a valid use case (which I gather you are saying it is), then I will leave this marked as such. Thanks for the clarification.