search

openhackathons-org / gpubootcamp

This repository consists for gpu bootcamp material for HPC and AI
Apache License 2.0
513 stars 254 forks source link

[HPC_AI][AI for Science Climate] Text pre-processing notebook throws pandas error #111

Closed pzharrington closed 1 year ago

pzharrington commented 2 years ago

In file Pre-Processing_Text_data.ipynb, there is a pandas call that is out of date for pandas>=1.4, but the Dockerfile does not specify a specific pandas version during installation. The line in question is:

pd.set_option("max_columns", None)

Should be updated to 

pd.set_option("display.max_columns", None)

Otherwise, pandas<1.4 should be specified in the Dockerfile. See https://github.com/pandas-dev/pandas/issues/45619

bharatk-parallel commented 2 years ago

Valid observation. Will be updated

aswinkumar1999 commented 2 years ago

Thank you @pzharrington for bringing it up.

I've created a pull request #112 wherein I had set the pandas version explicitly to 1.3.5 and had built and tested the container for reliability.

Requesting @bharatk-parallel to review and merge the request.

aswinkumar1999 commented 1 year ago

Fixed in #112

Closing issue.