HMAC auth on secret-service returns 413 https status code

openintegrationhub / openintegrationhub

Open Integration Hub

http://www.openintegrationhub.org

Apache License 2.0

177 stars 47 forks source link

HMAC auth on secret-service returns 413 https status code #1499

Closed winklerj closed 9 months ago

winklerj commented 9 months ago

when body is larger than 100kb https://www.npmjs.com/package/body-parser#bodyparserjsonoptions

What has changed?

I changed the default to 1mb and made the value configurable.
I also noticed body-parser wasn't listed as a dependency in the package.json and added it

Does a specific change require especially careful review? N/A

What is still open or a known issue? N/A

Release Notes Made secret-service request body limit configurable

weberjm commented 9 months ago

That is strange that body-parser wasn't listed. I guess because of the way the packages were built using workspaces, the library always existed anyway in node_modules/. I guess technically body-parser isn't needed anymore in express, but we'll go with it for the moment.