search

openjfx / javafx-gradle-plugin

Gradle plugin that makes it easy to work with JavaFX 11+
https://openjfx.io/
BSD 3-Clause "New" or "Revised" License
359 stars 62 forks source link

Issue #85: Allow more than one configuration to be given. #115

Closed effad closed 1 year ago

effad commented 3 years ago

This PR fixes the problem that only one configuration can be specified which makes it impossible to use the plugin in conjunction with gradle test-fixtures (https://docs.gradle.org/current/userguide/java_testing.html#sec:java_test_fixtures) that need to access JavaFX as well and have their own configuration (testFixturesApi). Note that if this PR is acceptable, README.md should also be edited to reflect the possibility of multiple configurations.

FlorianKirmaier commented 2 years ago

Nice, exactly, what I would have needed today. This is even downwards compatible, right? Can we get this merged? @abhinayagarwal @peredadnr

palexdev commented 1 year ago

Why is this still unmerged? There hasn't been an update to this plugin in ages We need this fix asap

abhinayagarwal commented 1 year ago

@palexdev I am more interested in getting #137 merged. Please check my comment on #137

palexdev commented 1 year ago

@abhinayagarwal ah I see that is an extension of this I hope it gets merged soon Running JavaFX tests can be quite cumbersome at the moment

abhinayagarwal commented 1 year ago

@palexdev I have pushed a couple of changes to #137 , would you be kind enough to test the same?

palexdev commented 1 year ago

@abhinayagarwal No problem! I'll report asap

abhinayagarwal commented 1 year ago

superseded by #137