openjfx / javafx-gradle-plugin

Gradle plugin that makes it easy to work with JavaFX 11+
https://openjfx.io/
BSD 3-Clause "New" or "Revised" License
361 stars 62 forks source link

Add support to declare modules as `api` #29

Closed abhinayagarwal closed 5 years ago

abhinayagarwal commented 5 years ago

All dependencies declared via the following block are added as implementation:

javafx {
    modules 'javafx.graphics'
}

There should be a way to declare these dependencies as api as well.

altavir commented 5 years ago

It was discussed at #5. I am not sure I am fully convinced, but I do not have a lot of experience with modules.

se7kn8 commented 5 years ago

What about the javafx.base module? As far as I know, this module doesn't require the native dependencies, which are mentioned in #5.

jperedadnr commented 5 years ago

Fixed with #41