search

openjfx / javafx-gradle-plugin

Gradle plugin that makes it easy to work with JavaFX 11+
https://openjfx.io/
BSD 3-Clause "New" or "Revised" License
359 stars 62 forks source link

Add gradle wrapper validation #80

Closed koppor closed 4 years ago

koppor commented 4 years ago

There is a gradle wrapper validation action available. This PR enables it for this repo.

Reason: PRs https://github.com/openjfx/javafx-gradle-plugin/pull/79 and https://github.com/openjfx/javafx-gradle-plugin/pull/74 are touching the gradle binaries. Who knows whether non-good code was introduced there.

msgilligan commented 4 years ago

Note that Gradle wrapper validation could also be added to the existing Github workflow YAML file...

koppor commented 4 years ago

Please point me to the existing GitHub workflow YAML file.

Currently, this repository seems to rely on TravisCI. Therefore, I followed the second proposal from the action's repository:

https://github.com/gradle/wrapper-validation-action#add-a-new-dedicated-workflow

grafik

msgilligan commented 4 years ago

Please point me to the existing GitHub workflow YAML file.

Haha. Sorry! I didn't realize that there wasn't one already.