search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
697 stars 36 forks source link

[REVIEW]: MTEX2Gmsh: a tool for generating 2D meshes from EBSD data #2094

Closed whedon closed 3 years ago

whedon commented 4 years ago

Submitting author: @DorianDepriester (Dorian Depriester) Repository: https://github.com/DorianDepriester/mtex2Gmsh Version: v2.0.1 Editor: @meg-simula Reviewer: @streeve, @ralfHielscher Archive: 10.6084/m9.figshare.12839711

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/aef990e2d5098db30344a068f978ddbd"><img src="https://joss.theoj.org/papers/aef990e2d5098db30344a068f978ddbd/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/aef990e2d5098db30344a068f978ddbd/status.svg)](https://joss.theoj.org/papers/aef990e2d5098db30344a068f978ddbd)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@streeve & @ralfHielscher, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @meg-simula know.

✨ Please try and complete your review in the next two weeks ✨

Review checklist for @streeve

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

Review checklist for @ralfHielscher

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

whedon commented 4 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @streeve, @ralfHielscher it looks like you're currently assigned to review this paper :tada:.

:star: Important :star:

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 4 years ago 
Reference check summary:

OK DOIs

- 10.1088/0965-0393/24/5/055014 is OK
- 10.1016/j.actamat.2016.02.001 is OK
- 10.1016/0956-7151(94)90452-9 is OK
- 10.1364/AO.41.006815 is OK
- 10.1016/j.actamat.2016.10.030 is OK
- 10.1002/nme.2579 is OK
- 10.1016/j.ultramic.2011.08.002 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

meg-simula commented 4 years ago

@streeve @ralfHielscher Thanks again for agreeing to review. Reviewer checklists have been generated for each you above - take a look and dig in at will.

meg-simula commented 4 years ago

@streeve Thanks for your comments on this submission, looks like the review is progressing nicely.

@ralfHielscher Have you had a chance to start looking at this?

DorianDepriester commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

streeve commented 4 years ago

@meg-simula @DorianDepriester

I've completed the checklist and closed all the issues with my suggestions. This is a very nice code, combining the strengths of underlying tools. I'm no expert in this type of simulation, but the docs and examples make it clear what I could do with it.

One more note: I did not test the Abaqus portion (I do not have access)

meg-simula commented 4 years ago

Thanks @streeve for your prompt review and @DorianDepriester for the prompt response!

meg-simula commented 4 years ago

@ralfHielscher :wave: We are waiting on your review to proceed with this submission.

meg-simula commented 4 years ago

/ooo March 12 until March 27

ooo[bot] commented 4 years ago

:+1: Marked @meg-simula as OOO from Thursday, March 12th 2020 to Friday, March 27th 2020. :calendar:

arfon commented 4 years ago

Dear authors and reviewers

We wanted to notify you that in light of the current COVID-19 pandemic, JOSS has decided to suspend submission of new manuscripts and to handle existing manuscripts (such as this one) on a "best efforts basis". We understand that you may need to attend to more pressing issues than completing a review or updating a repository in response to a review. If this is the case, a quick note indicating that you need to put a "pause" on your involvement with a review would be appreciated but is not required.

Thanks in advance for your understanding.

Arfon Smith, Editor in Chief, on behalf of the JOSS editorial team.

arfon commented 4 years ago

:wave: @ralfHielscher, just a friendly check-in to see how things are going with your review?

arfon commented 4 years ago

👋 @ralfHielscher - today we reopened JOSS for new submissions and are checking in on our existing reviews. Do you think you might be able to wrap up your review in the next 2-3 weeks?

meg-simula commented 4 years ago

@ralfHielscher :wave: We are still waiting on your review to proceed with this submission. Could you give us an update?

meg-simula commented 4 years ago

Sorry for the delay on this review @DorianDepriester . I will unassign @ralfHielscher and find an alternative reviewer to get this process completed.

DorianDepriester commented 4 years ago

Hello there, Just to mention that @ralfHielscher has kindly reviewed the submission. https://github.com/DorianDepriester/MTEX2Gmsh/issues/5#issue-648501620 I am doing my best to promptly answer each bullet point.

meg-simula commented 4 years ago

Ok, thanks @ralfhielscher and @doriandepriester!

meg-simula commented 4 years ago

Just checking in here - all the boxes have been checked it seems - what are your thoughts on the current state of the submission @DorianDepriester @ralfHielscher

meg-simula commented 4 years ago

/ooo July 28 until August 10

ooo[bot] commented 4 years ago

:+1: Marked @meg-simula as OOO from Tuesday, July 28th 2020 to Monday, August 10th 2020. :calendar:

DorianDepriester commented 4 years ago

I have answered all the point raised by @ralfHielscher in the issue mentioned above. He seems satisfied for he has closed the issue.

meg-simula commented 4 years ago

Ok, great! I will proceed with this submission once I'm back from vacation.

meg-simula commented 3 years ago

@whedon check references

meg-simula commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right: Check article proof :page_facing_up: :point_left:

meg-simula commented 3 years ago

@DorianDepriester Thanks for your patience with this submission.

I've gone through the paper, and ask that you please consider the following suggestions:

meg-simula commented 3 years ago

@whedon check references

whedon commented 3 years ago 
Reference check summary:

OK DOIs

- 10.1088/0965-0393/24/5/055014 is OK
- 10.1016/j.actamat.2016.02.001 is OK
- 10.1016/0956-7151(94)90452-9 is OK
- 10.1364/AO.41.006815 is OK
- 10.1016/j.actamat.2016.10.030 is OK
- 10.1002/nme.2579 is OK
- 10.1016/j.ultramic.2011.08.002 is OK

MISSING DOIs

- None

INVALID DOIs

- None
DorianDepriester commented 3 years ago

@meg-simula, thank you for your feedback. Here are the answers to all the points you have raised:

DorianDepriester commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right: Check article proof :page_facing_up: :point_left:

meg-simula commented 3 years ago

Excellent, thanks @DorianDepriester!

At this point could you:

I can then move forward with accepting the submission

DorianDepriester commented 3 years ago

Hello @meg-simula, see below the items you have requested:

meg-simula commented 3 years ago

@whedon set 10.6084/m9.figshare.12839711 as archive

whedon commented 3 years ago

OK. 10.6084/m9.figshare.12839711 is the archive.

meg-simula commented 3 years ago

@whedon set v2.0.1 as version

whedon commented 3 years ago

OK. v2.0.1 is the version.

meg-simula commented 3 years ago

@whedon accept

whedon commented 3 years ago 
Attempting dry run of processing paper acceptance...
whedon commented 3 years ago 
Reference check summary:

OK DOIs

- 10.1088/0965-0393/24/5/055014 is OK
- 10.1016/j.actamat.2016.02.001 is OK
- 10.1016/0956-7151(94)90452-9 is OK
- 10.1364/AO.41.006815 is OK
- 10.1016/j.actamat.2016.10.030 is OK
- 10.1002/nme.2579 is OK
- 10.1016/j.ultramic.2011.08.002 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 3 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/1660

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/1660, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
arfon commented 3 years ago

@whedon accept deposit=true

whedon commented 3 years ago 
Doing it live! Attempting automated processing of paper acceptance...
whedon commented 3 years ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

whedon commented 3 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/1661
  2. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.02094
  3. If everything looks good, then close this review issue.

  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

    Any issues? Notify your editorial technical team...

arfon commented 3 years ago

@streeve, @ralfHielscher - many thanks for your reviews here and to @meg-simula for editing this submission :sparkles:

@DorianDepriester - your paper is now accepted into JOSS :zap::rocket::boom:

whedon commented 3 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.02094/status.svg)](https://doi.org/10.21105/joss.02094)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.02094">
  <img src="https://joss.theoj.org/papers/10.21105/joss.02094/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.02094/status.svg
   :target: https://doi.org/10.21105/joss.02094

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: