openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: arcos (R) and arcospy (Python): twin software packages to access the DEA ARCOS database from 2006 to 2014 #2223

Closed whedon closed 4 years ago

whedon commented 4 years ago

Submitting author: @jeffcsauer (Jeffery Sauer) Repository: https://github.com/jeffcsauer/arcos_arcospy_information Version: arcos (1.1); arcospy (1.1.0) Editor: @bmcfee Reviewers: @jaeyk, @edonnachie Managing EiC: Arfon Smith

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @jeffcsauer. Currently, there isn't an JOSS editor assigned to your paper.

@jeffcsauer if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 4 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 4 years ago
Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.02 s (243.6 files/s, 11451.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Markdown                         3             52              0             94
TeX                              1              4              0             38
-------------------------------------------------------------------------------
SUM:                             4             56              0            132
-------------------------------------------------------------------------------

Statistical information for the repository '2223' was gathered on 2020/05/22.
No commited files with the specified extensions were found.
whedon commented 4 years ago
Reference check summary:

OK DOIs

- doi:10.1016/j.drugpo.2019.03.024 is OK
- doi:10.1016/j.jpainsymman.2004.01.003 is OK
- doi:10.1001/jama.283.13.1710 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

arfon commented 4 years ago

:wave: @jeffcsauer - could you link the related software repositories here please?

arfon commented 4 years ago

:wave: @lorenanicole - would you be willing to edit this submission for JOSS?

arfon commented 4 years ago

@whedon invite @lorenanicole as editor

whedon commented 4 years ago

@lorenanicole has been invited to edit this submission.

jeffcsauer commented 4 years ago

Sure, no problem! Thanks for assigning and inviting an editor.

Link to arcos (r) repository

Link to arcospy (python) repository

Both links are also present in the article under the Availability section.

danielskatz commented 4 years ago

👋 @lorenanicole - just a reminder here that you have been invited to edit this submission as well (and no more are coming to you in the immediate future)

arfon commented 4 years ago

:wave: @jeffcsauer - @lorenanicole is a new editor and is already handling two JOSS submissions and so won't be able to take this one on. I'm going to mark this as waitlisted for now due to the large volume of submissions that have been received by JOSS in the last week but expect we'll be able to identify a handling editor relatively soon.

Thanks in advance for your patience!

jeffcsauer commented 4 years ago

Sounds good! Thank you for the follow-up.

kyleniemeyer commented 4 years ago

Hey @bmcfee, could you take this one on as your first editing assignment?

kyleniemeyer commented 4 years ago

@whedon invite @bmcfee as editor

whedon commented 4 years ago

@bmcfee has been invited to edit this submission.

bmcfee commented 4 years ago

@whedon assign @bmcfee as editor

whedon commented 4 years ago

I'm sorry @bmcfee, I'm afraid I can't do that. That's something only editors are allowed to do.

arfon commented 4 years ago

@whedon list editors

whedon commented 4 years ago

Current editors:

@Kevin-Mattheus-Moerman
@KristinaRiemer
@VivianePons
@akeshavan
@arfon
@arokem
@bmcfee
@cMadan
@csoneson
@danielskatz
@dfm
@dhhagan
@diehlpk
@dpsanders
@drvinceknight
@gkthiruvathukal
@harpolea
@hugoledoux
@jedbrown
@jgostick
@karthik
@katyhuff
@kbarnhart
@kthyng
@kyleniemeyer
@labarba
@leouieda
@lorenanicole
@lpantano
@majensen
@marcosvital
@mbobra
@meg-simula
@melissawm
@mikldk
@mjsottile
@oliviaguest
@pdebuyl
@pibion
@poulson
@richardjgowers
@sjpfenninger
@terrytangyuan
@trallard
@usethedata
@will-rowe
@xuanxu
arfon commented 4 years ago

@bmcfee try again now...

bmcfee commented 4 years ago

@whedon assign @bmcfee as editor

whedon commented 4 years ago

OK, the editor is @bmcfee

bmcfee commented 4 years ago

Thanks @arfon !

bmcfee commented 4 years ago

@jeffcsauer :wave: Things look generally good so far, so I'll get to finding some reviewers over the next few days.

In the meantime, I've noticed that the LICENSE file in one of the repos doesn't quite line up with the license listed in the submission repository. These should be made complete and consistent to satisfy the submission requirements.

bmcfee commented 4 years ago

@mariacuellar @mkearney This looks like it could be up your respective alleys -- are you interested/available to review?

jeffcsauer commented 4 years ago

@bmcfee thanks for catching that! Reaching out to co-authors to clarify this and will update ASAP.

jeffcsauer commented 4 years ago

@bmcfee spoke with co-author and updated LICENSE file in arcos_arcospy_information and arcospy to follow the lead of arcos. All LICENSE files across the software repositories and JOSS paper repo page are now consistent.

bmcfee commented 4 years ago

Thanks @jeffcsauer, however it now appears that these packages are not using a standard OSS license? The README says "MIT", but the full text of the license should be included in the repository/ies (as per submission guidelines).

jeffcsauer commented 4 years ago

@bmcfee thanks for pointing this out! I spoke again with the co-author and confirmed the MIT + file LICENSE is the appropriate template. I updated the arcos_arcospy_information LICENSE file to avoid confusion. Could you confirm this is now conforms to submission guidelines?

bmcfee commented 4 years ago

Just a heads up on this, since it's been a couple of weeks. I'm still working on finding reviewers, but your patience is appreciated!

jeffcsauer commented 4 years ago

No worries, thanks for the update!

bmcfee commented 4 years ago

@whedon add @jaeyk as reviewer

whedon commented 4 years ago

OK, @jaeyk is now a reviewer

bmcfee commented 4 years ago

@whedon add @edonnachie as reviewer

whedon commented 4 years ago

OK, @edonnachie is now a reviewer

bmcfee commented 4 years ago

@whedon start review

whedon commented 4 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/2450.