[REVIEW]: CosmicProfiles: A Python package for radial profiling of finitely sampled dark matter halos and galaxies

[editorialbot]

Submitting author: !--author-handle-->@tibordome<!--end-author-handle-- (Tibor Dome) Repository: https://github.com/tibordome/cosmic_profiles Branch with paper.md (empty if default branch): dev Version: v1.4.0 Editor: !--editor-->@adonath<!--end-editor-- Reviewers: @benediktdiemer, @phil-mansfield Archive: 10.5281/zenodo.7934897

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/cc4b94fdf39b15f91d497c0b50b459e0"><img src="https://joss.theoj.org/papers/cc4b94fdf39b15f91d497c0b50b459e0/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/cc4b94fdf39b15f91d497c0b50b459e0/status.svg)](https://joss.theoj.org/papers/cc4b94fdf39b15f91d497c0b50b459e0)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@benediktdiemer & @phil-mansfield, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @adonath know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @benediktdiemer

📝 Checklist for @phil-mansfield

[adonath]

Thanks a lot @tibordome, I have no further comments! Please make a new tagged release and archive of the software (e.g. Zenodo), and report the version number and archive DOI here in this thread.

[adonath]

@tibordome One minor thing: can you please replace the shortcuts like \mnras in the .bib file by the full journal names. It seems currently the journal names are not rendered correctly in the references of the paper. Thanks!

[tibordome]

@adonath many thanks for pointing that out. I have fixed the \mnras shortcuts, made a tagged release (version number v1.4.0) and archived the repo on Zenodo. The archive DOI would be

[adonath]

@editorialbot set v1.4.0 as version

[editorialbot]

Done! version is now v1.4.0

[adonath]

@editorialbot set 10.5281/zenodo.7934897 as archive

[editorialbot]

Done! archive is now 10.5281/zenodo.7934897

[adonath]

@editorialbot recommend-accept

[editorialbot]

Attempting dry run of processing paper acceptance...

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/j.1365-2966.2009.15715.x is OK
- 10.1093/mnras/stac3766 is OK
- 10.3847/1538-3881/aadae0 is OK
- 10.3847/1538-4365/aaee8c is OK
- 10.1093/mnras/stac878 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[editorialbot]

:wave: @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4228, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

[dfm]

@tibordome — I'm doing the final processing of this submission. Can you update the metadata on the Zenodo record (there should be an "Edit" button the record page if you're logged in) so that the title and author list exactly match the paper? Then it looks like we're all set!

Edit: Whoops! I meant @tibordome not @phil-mansfield - sorry!!

[phil-mansfield]

(was just about to clarify, ha ha)

[tibordome]

@dfm I have updated the metadata. The title and author list should now match exactly

[dfm]

@editorialbot accept

[editorialbot]

Doing it live! Attempting automated processing of paper acceptance...

[editorialbot]

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Dome given-names: Tibor orcid: "https://orcid.org/0000-0003-2586-3702" doi: 10.5281/zenodo.7934897 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Dome given-names: Tibor orcid: "https://orcid.org/0000-0003-2586-3702" date-published: 2023-05-16 doi: 10.21105/joss.05008 issn: 2475-9066 issue: 85 journal: Journal of Open Source Software publisher: name: Open Journals start: 5008 title: "CosmicProfiles: A Python package for radial profiling of finitely sampled dark matter halos and galaxies" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05008" volume: 8 title: "CosmicProfiles: A Python package for radial profiling of finitely sampled dark matter halos and galaxies" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

[editorialbot]

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

[editorialbot]

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

[editorialbot]

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

0. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4234
1. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05008
2. If everything looks good, then close this review issue.
3. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

[dfm]

Many thanks to @benediktdiemer and @phil-mansfield for reviewing and to @adonath for editing! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!!

@tibordome — Your paper is now accepted and published in JOSS! :zap::rocket::boom:

[editorialbot]

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05008/status.svg)](https://doi.org/10.21105/joss.05008)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05008">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05008/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05008/status.svg
   :target: https://doi.org/10.21105/joss.05008

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

• Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
• Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

[adonath]

Congratulations @tibordome!

[tibordome]

Many thanks. Thank you @adonath for editing and @benediktdiemer and @phil-mansfield for the fantastic reviews!