openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[REVIEW]: DARTS: The Data Analysis Remote Treatment Service #5562

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@farhi<!--end-author-handle-- (Emmanuel FARHI) Repository: https://gitlab.com/soleil-data-treatment/soleil-software-projects/remote-desktop Branch with paper.md (empty if default branch): Version: v23.10.18 Editor: !--editor-->@mbobra<!--end-editor-- Reviewers: @ebknudsen, @dfeich Archive: 10.5281/zenodo.8189000

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/e0ccca212a6da76335312e0e2755c993"><img src="https://joss.theoj.org/papers/e0ccca212a6da76335312e0e2755c993/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/e0ccca212a6da76335312e0e2755c993/status.svg)](https://joss.theoj.org/papers/e0ccca212a6da76335312e0e2755c993)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@ebknudsen & @dfeich, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @mbobra know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

πŸ“ Checklist for @ebknudsen

πŸ“ Checklist for @dfeich

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

farhi commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1002/smll.201802291 is OK
- 10.1109/JCDL.2017.7991618 is OK
- 10.3030/957189 is OK
- 10.17199/NOBUGS2016.65 is OK
- 10.1016/j.ecoinf.2016.08.003 is OK

MISSING DOIs

- None

INVALID DOIs

- None
farhi commented 1 year ago

All clear now !

mbobra commented 1 year ago

@farhi Does this Zenodo deposit include all of the changes implemented during the referee process? If so, could you please change the title of the record to exactly match the title of the paper? If not, could you please cut a new release that include all the changes?

farhi commented 1 year ago

Hi @mbobra the Zenodo entry has been updated with the latest code and paper. Thanks.

mbobra commented 1 year ago

@editorialbot set 10.5281/zenodo.8189000 as archive

editorialbot commented 1 year ago

Done! archive is now 10.5281/zenodo.8189000

mbobra commented 1 year ago

@editorialbot set v23.10.18 as version

editorialbot commented 1 year ago

Done! version is now v23.10.18

mbobra commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago
Attempting dry run of processing paper acceptance...
editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1002/smll.201802291 is OK
- 10.1109/JCDL.2017.7991618 is OK
- 10.3030/957189 is OK
- 10.17199/NOBUGS2016.65 is OK
- 10.1016/j.ecoinf.2016.08.003 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 1 year ago

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4703, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

mbobra commented 1 year ago

Thank you both so very much for your thorough reviews, @ebknudsen and @dfeich! Your volunteer time keeps JOSS running and the JOSS team appreciates it very much β˜€οΈ

mbobra commented 1 year ago

Thank you for your submission and all the edits, @farhi! I hope you feel it improved the code. This is a really nice paper!

farhi commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago

I'm sorry @farhi, I'm afraid I can't do that. That's something only eics are allowed to do.

danielskatz commented 1 year ago

@farhi - I'm the track editor, and will handle the rest of your process. I've proofread the paper, and have suggested some small changes in https://gitlab.com/soleil-data-treatment/soleil-software-projects/remote-desktop/-/merge_requests/10 - please merge this or let me know what you disagree with, then we can proceed

farhi commented 1 year ago

Hi Daniel, this is now merged. Thanks.

danielskatz commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago
Attempting dry run of processing paper acceptance...
editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1002/smll.201802291 is OK
- 10.3233/978-1-61499-649-1-87 is OK
- 10.1109/JCDL.2017.7991618 is OK
- 10.3030/957189 is OK
- 10.17199/NOBUGS2016.65 is OK
- 10.1016/j.ecoinf.2016.08.003 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 1 year ago

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4708, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 1 year ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Farhi given-names: Emmanuel orcid: "https://orcid.org/0000-0002-8508-8106" doi: 10.5281/zenodo.8189000 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Farhi given-names: Emmanuel orcid: "https://orcid.org/0000-0002-8508-8106" date-published: 2023-10-19 doi: 10.21105/joss.05562 issn: 2475-9066 issue: 90 journal: Journal of Open Source Software publisher: name: Open Journals start: 5562 title: "DARTS: The Data Analysis Remote Treatment Service" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05562" volume: 8 title: "DARTS: The Data Analysis Remote Treatment Service" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 1 year ago

🐘🐘🐘 πŸ‘‰ Toot for this paper πŸ‘ˆ 🐘🐘🐘

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4709
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05562
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! πŸŽ‰πŸŒˆπŸ¦„πŸ’ƒπŸ‘»πŸ€˜

Any issues? Notify your editorial technical team...

danielskatz commented 1 year ago

Congratulations to @farhi (Emmanuel FARHI) on your publication!!

And thanks to @ebknudsen and @dfeich for reviewing, and to @mbobra for editing! JOSS is volunteer-based, and we couldn't do this without you

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05562/status.svg)](https://doi.org/10.21105/joss.05562)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05562">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05562/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05562/status.svg
   :target: https://doi.org/10.21105/joss.05562

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: