search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
712 stars 38 forks source link

[PRE REVIEW]: pyheartlib: A Python package for processing electrocardiogram signals #5568

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@devnums<!--end-author-handle-- (Sadegh Mohammadi) Repository: https://github.com/devnums/pyheartlib Branch with paper.md (empty if default branch): paper Version: v1.0.1 Editor: !--editor-->@britta-wstnr<!--end-editor-- Reviewers: @cudmore, @LegrandNico Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/4c9af4eef164d4647174e8a225a416e8"><img src="https://joss.theoj.org/papers/4c9af4eef164d4647174e8a225a416e8/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/4c9af4eef164d4647174e8a225a416e8/status.svg)](https://joss.theoj.org/papers/4c9af4eef164d4647174e8a225a416e8)

Author instructions

Thanks for submitting your paper to JOSS @devnums. Currently, there isn't a JOSS editor assigned to your paper.

@devnums if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago 
Software report:

github.com/AlDanial/cloc v 1.88  T=0.06 s (1039.2 files/s, 100078.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          32            646           1323           2512
Markdown                         9            109              0            179
YAML                             6             39             23            153
Jupyter Notebook                 4              0            535            140
TeX                              1              5              0            103
TOML                             1              5              0             45
DOS Batch                        1              8              1             27
reStructuredText                 6             25             35             22
Bourne Shell                     1              5              2             10
make                             1              4              5             10
-------------------------------------------------------------------------------
SUM:                            62            846           1924           3201
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/51.932724 is OK
- 10.1161/01.CIR.101.23.e215 is OK
- 10.13026/9njx-6322 is OK
- 10.13026/zzpx-h016 is OK

MISSING DOIs

- 10.1163/1574-9347_dnp_e612900 may be a valid DOI for title: Keras

INVALID DOIs

- None
editorialbot commented 1 year ago

Wordcount for paper.md is 247

editorialbot commented 1 year ago

:warning: An error happened when generating the pdf.

danielskatz commented 1 year ago

👋 @devnums - your paper is not compiling. I think this is because you don't have an affiliation listed in the header in the paper.md file. Please follow the example paper and note that you can click on the error above to find out more about it.

Please feel free to make changes to your .md file, then use the command @editorialbot generate pdf to make a new PDF. editorialbot commands need to be the first entry in a new comment.

Your paper is also remarkably short. In addition to the example paper and the documentation about paper requirements, please see the other recently published papers for some examples.

danielskatz commented 1 year ago

👋 @bmcfee - Would you be able to edit this submission, once the paper issues are resolved, and assuming it is in scope?

danielskatz commented 1 year ago

@editorialbot invite @bmcfee as editor

editorialbot commented 1 year ago

Invitation to edit this submission sent!

bmcfee commented 1 year ago

Thanks for the invite, but I'm unavailable for new assignments right now.

danielskatz commented 1 year ago

👋 @britta-wstnr - would you be able to edit this submission, once the paper issues are resolved, and assuming it is in scope?

danielskatz commented 1 year ago

@editorialbot invite @britta-wstnr as editor

editorialbot commented 1 year ago

Invitation to edit this submission sent!

devnums commented 1 year ago

@editorialbot commands

editorialbot commented 1 year ago

Hello @devnums, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers
devnums commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

devnums commented 1 year ago

@danielskatz Thank you for your suggestions. The paper has been edited and successfully compiled.

danielskatz commented 1 year ago

👋 @britta-wstnr - ping (re above invitation to edit)

britta-wstnr commented 1 year ago

Hi @danielskatz - sorry for my late reply, I was traveling last week. Yes, I can take this one on!

britta-wstnr commented 1 year ago

@editorialbot assign @britta-wstnr as editor

editorialbot commented 1 year ago

Assigned! @britta-wstnr is now the editor

britta-wstnr commented 1 year ago

Hi @devnums, I will be handling your submission. - I will start inviting reviewers, if you have any ideas for potential reviewers, you can suggest them here --- please read the guidelines in the editorialbot's first comment on how to search for reviewers and how to mention them here (don't "@" them, please).

I will be back shortly! 🙂 🌱

britta-wstnr commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/51.932724 is OK
- 10.1161/01.CIR.101.23.e215 is OK
- 10.13026/9njx-6322 is OK
- 10.13026/zzpx-h016 is OK
- 10.3758/s13428-020-01516-y is OK

MISSING DOIs

- None

INVALID DOIs

- None
britta-wstnr commented 1 year ago

Hi @peterakirk and @cudmore :wave:

Would you be willing to review the submission: pyheartlib: A Python package for processing electrocardiogram signals for The Journal of Open Source Software (JOSS)?

The review concerns the software pyheartlib and a short paper about it. The review happens fully on GitHub.

You can learn more about the the review process and our conflict of interest policy in the reviewer guidelines here.

If you are available to review this submission, please let me know and I can add you as a reviewer. The review process will start (in a separate GitHub issue) once a sufficient number of reviewers have been found.

Thank you! Britta

britta-wstnr commented 1 year ago

ping @peterakirk and @cudmore Kind reminder for my review invitation (see comment above) 🙏

peterakirk commented 1 year ago

Hi @britta-wstnr, my thesis is due in 2 weeks, so I unfortunately don't have the time. Happy to recommend reviewers if you want.

Thanks, Pete

cudmore commented 1 year ago

Yes, I am happy to review.

Robert

On Tue, Jul 4, 2023 at 1:11 AM Britta Westner @.***> wrote:

ping @peterakirk https://github.com/peterakirk and @cudmore https://github.com/cudmore Kind reminder for my review invitation (see comment above https://github.com/openjournals/joss-reviews/issues/5568#issuecomment-1611629045) 🙏

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/5568#issuecomment-1619755249, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHWMEGZ5WXXKBQ2KN6BWV3XOPF4RANCNFSM6AAAAAAZKLKS54 . You are receiving this because you were mentioned.Message ID: @.***>

devnums commented 1 year ago

Hi @britta-wstnr 👋, Thank you for taking the time to handle my paper. I've found additional reviewers from the list.

Gabrock94 pzelasko

Best regards

britta-wstnr commented 1 year ago

@cudmore - amazing, thanks! 🙏 The reviewing process will start as soon as I have found a sufficient number of reviewers. I will ping you then.

@peterakirk - I understand. Good luck with finishing your thesis! 🍀

britta-wstnr commented 1 year ago

@LegrandNico has agreed vie email to review this paper as well - thanks! :pray: You will get pinged again once the reviewing process starts.

britta-wstnr commented 1 year ago

Hi @Gabrock94 👋

Would you be willing to review the submission: pyheartlib: A Python package for processing electrocardiogram signals for The Journal of Open Source Software (JOSS)?

The review concerns the software pyheartlib and a short paper about it. The review happens fully on GitHub.

You can learn more about the the review process and our conflict of interest policy in the reviewer guidelines here.

If you are available to review this submission, please let me know and I can add you as a reviewer. The review process will start (in a separate GitHub issue) once a sufficient number of reviewers have been found.

Thank you! Britta

britta-wstnr commented 1 year ago

ping @Gabrock94 👋 kind reminder for my review invitation (see comment above) 🙏

Gabrock94 commented 1 year ago

ping @Gabrock94 wave kind reminder for my review invitation (see comment above) pray

HI @britta-wstnr , sorry I completely missed the first notification. I will work on it in the coming days.

Best, Giulio

britta-wstnr commented 1 year ago

Thanks @Gabrock94 - looking forward to hearing if you would be available to review this! 🙂

britta-wstnr commented 1 year ago

Ping @Gabrock94 - have you decided yet if you would be willing to review this? 🙂

Gabrock94 commented 1 year ago

Ping @Gabrock94 - have you decided yet if you would be willing to review this? 🙂

Yes I am working on it. I need likely 2 more days :)

devnums commented 1 year ago

Hi @britta-wstnr 👋

Here is another list of potential reviewers who might be interested.

pzelasko jerodway saran-nns vjbytes102 Bsingstad jwwthu neurofractal TomDonoghue

The list is not arranged in a particular order. Kindly contact them or any other reviewer that you believe would be more suitable.

Thank you for you time 🙏 Sadegh

britta-wstnr commented 1 year ago

Hi @devnums - thank you for the list (and sorry for being slow here, I had too many other things on my plate last week).

britta-wstnr commented 1 year ago

Hi @TomDonoghue and @Bsingstad 👋

Would one of you be willing to review the submission: pyheartlib: A Python package for processing electrocardiogram signals for The Journal of Open Source Software (JOSS)?

The review concerns the software pyheartlib and a short paper about it. The review happens fully on GitHub.

You can learn more about the the review process and our conflict of interest policy in the reviewer guidelines here.

If you are available to review this submission, please let me know and I can add you as a reviewer. The review process will start (in a separate GitHub issue) once a sufficient number of reviewers have been found.

Thank you! Britta

TomDonoghue commented 1 year ago

Hey @britta-wstnr - thanks for the invite! Unfortunately, I have no practical experience with measuring cardiac signals to help me assess this package, and am also currently quite limited in my schedule, so I'm going to have to pass on this one!

britta-wstnr commented 1 year ago

Hi @TomDonoghue, I understand! Thank you very much for getting back to me! 🙏

britta-wstnr commented 1 year ago

Ping @Bsingstad 👋 Kind reminder for my review invitation (see comment above) 🙏

britta-wstnr commented 1 year ago

@editorialbot add @cudmore as reviewer

editorialbot commented 1 year ago

@cudmore added to the reviewers list!

britta-wstnr commented 1 year ago

@editorialbot add @LegrandNico as reviewer

editorialbot commented 1 year ago

@LegrandNico added to the reviewers list!

britta-wstnr commented 1 year ago

Hi 
@cudmore and @LegrandNico and hi @devnums, it's been tough finding a third reviewer here (🏖️ time?), so let's move this submission to the reviewing step 🌱 . That means that this PRE-REVIEW will be closed and you will be pinged in a new thread - there'll be detailed info how to proceed there as well!

britta-wstnr commented 1 year ago

@editorialbot start review