openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: Viash: A meta-framework for building reusable workflow modules #6075

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@rcannood<!--end-author-handle-- (Robrecht Cannoodt) Repository: https://github.com/viash-io/viash Branch with paper.md (empty if default branch): paper Version: 0.8.1 Editor: !--editor-->@danielskatz<!--end-editor-- Reviewers: @wilkinson, @abhishektiwari, @mberacochea Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f7d328cfad31d61f90eade9dfdb2ef8c"><img src="https://joss.theoj.org/papers/f7d328cfad31d61f90eade9dfdb2ef8c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f7d328cfad31d61f90eade9dfdb2ef8c/status.svg)](https://joss.theoj.org/papers/f7d328cfad31d61f90eade9dfdb2ef8c)

Author instructions

Thanks for submitting your paper to JOSS @rcannood. Currently, there isn't a JOSS editor assigned to your paper.

@rcannood if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.01 s (492.3 files/s, 30686.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Markdown                         2             48              0             85
TeX                              1             11              0             43
-------------------------------------------------------------------------------
SUM:                             3             59              0            128
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 1876

editorialbot commented 1 year ago

Failed to discover a valid open source license

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/bioinformatics/bts480 is OK
- 10.1038/s41592-019-0654-x is OK
- 10.1038/s41576-023-00586-w is OK
- 10.15252/msb.20188746 is OK
- 10.1038/s41587-020-0439-x is OK
- 10.1038/nbt.3820 is OK
- 10.5281/ZENODO.4638196 is OK
- 10.5281/ZENODO.4735634 is OK
- 10.1371/journal.pone.0177459 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 year ago

Five most similar historical JOSS papers:

nf-gwas-pipeline: A Nextflow Genome-Wide Association Study Pipeline Submitting author: @ZeyuanSong Handling editor: @lpantano (Active) Reviewers: @preetida, @rspirgel Similarity score: 0.8333

MetaGenePipe: An Automated, Portable Pipeline for Contig-based Functional and Taxonomic Analysis Submitting author: @ParkvilleData Handling editor: @jmschrei (Active) Reviewers: @Ebedthan, @rjorton Similarity score: 0.8208

BioProv - A provenance library for bioinformatics workflows Submitting author: @vinisalazar Handling editor: @jmschrei (Active) Reviewers: @maximtrp, @Zethson Similarity score: 0.8190

RAILS and Cobbler: Scaffolding and automated finishing of draft genomes using long DNA sequences Submitting author: @warrenlr Handling editor: @biorelated (Retired) Reviewers: @andrewjpage Similarity score: 0.8181

DARE Platform: a Developer-Friendly and Self-Optimising Workflows-as-a-Service Framework for e-Science on the Cloud Submitting author: @iaklampanos Handling editor: @danielskatz (Active) Reviewers: @rafaelfsilva, @Himscipy Similarity score: 0.8180

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

danielskatz commented 1 year ago

👋 @rcannood - JOSS works best when the paper branch contains the software as well, not just the paper. Can you please change the paper branch of be a copy of main that also includes the paper, rather than just the paper?

danielskatz commented 1 year ago

Also, your figures are not appearing in the draft paper. Please follow the example paper. Please feel free to make changes to your .md file, then use the command @editorialbot generate pdf to make a new PDF. editorialbot commands need to be the first entry in a new comment.

rcannood commented 1 year ago

Thanks @danielskatz ! I'll make some changes to make the paper render properly. It's strange because when I rendered the paper locally using docker run ... openjournals/inara, everything looks ok.

rcannood commented 1 year ago

@editorialbot generate pdf

rcannood commented 1 year ago

@editorialbot commands

editorialbot commented 1 year ago

Hello @rcannood, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers
editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 year ago

Five most similar historical JOSS papers:

nf-gwas-pipeline: A Nextflow Genome-Wide Association Study Pipeline Submitting author: @ZeyuanSong Handling editor: @lpantano (Active) Reviewers: @preetida, @rspirgel Similarity score: 0.8333

MetaGenePipe: An Automated, Portable Pipeline for Contig-based Functional and Taxonomic Analysis Submitting author: @ParkvilleData Handling editor: @jmschrei (Active) Reviewers: @Ebedthan, @rjorton Similarity score: 0.8208

BioProv - A provenance library for bioinformatics workflows Submitting author: @vinisalazar Handling editor: @jmschrei (Active) Reviewers: @maximtrp, @Zethson Similarity score: 0.8190

RAILS and Cobbler: Scaffolding and automated finishing of draft genomes using long DNA sequences Submitting author: @warrenlr Handling editor: @biorelated (Retired) Reviewers: @andrewjpage Similarity score: 0.8181

DARE Platform: a Developer-Friendly and Self-Optimising Workflows-as-a-Service Framework for e-Science on the Cloud Submitting author: @iaklampanos Handling editor: @danielskatz (Active) Reviewers: @rafaelfsilva, @Himscipy Similarity score: 0.8180

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

rcannood commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 year ago

Five most similar historical JOSS papers:

nf-gwas-pipeline: A Nextflow Genome-Wide Association Study Pipeline Submitting author: @ZeyuanSong Handling editor: @lpantano (Active) Reviewers: @preetida, @rspirgel Similarity score: 0.8280

MetaGenePipe: An Automated, Portable Pipeline for Contig-based Functional and Taxonomic Analysis Submitting author: @ParkvilleData Handling editor: @jmschrei (Active) Reviewers: @Ebedthan, @rjorton Similarity score: 0.8197

Pipengine: an ultra light YAML-based pipeline execution engine Submitting author: @fstrozzi Handling editor: @biorelated (Retired) Reviewers: @yannickwurm Similarity score: 0.8173

BioProv - A provenance library for bioinformatics workflows Submitting author: @vinisalazar Handling editor: @jmschrei (Active) Reviewers: @maximtrp, @Zethson Similarity score: 0.8121

SIAL: A simple image analysis library for wet-lab scientists Submitting author: @d-tear Handling editor: @jni (Retired) Reviewers: @bogovicj, @haesleinhuepf Similarity score: 0.8110

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

rcannood commented 1 year ago

@danielskatz Looks like all the figures are there now :)

rcannood commented 1 year ago

@danielskatz Here is a potential list of reviewers:

danielskatz commented 1 year ago

@editorialbot check repository

editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.29 s (1058.7 files/s, 151056.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Scala                          195           3439           3538          18353
SVG                              4              0              0          11803
Markdown                         7           1033              0           2310
YAML                            44             33             19           1444
Bourne Shell                    46            273            219           1392
Python                           8             52             19            144
JavaScript                       1              9              4             65
TeX                              1             11              0             43
R                                1              8             14             40
JSON                             1              1              0             20
Dockerfile                       1              6              7             18
EJS                              1              0              0              9
Rmd                              1              9             40              0
-------------------------------------------------------------------------------
SUM:                           311           4874           3860          35641
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 1872

danielskatz commented 1 year ago

@rcannood - thanks for your changes. I'll assign myself as the editor and get started on looking for reviewers.

As a note, this paper is fairly long now (JOSS recommends 1000 words as a maximum), so if you add anything during the review process, please find something else to remove at the same time.

danielskatz commented 1 year ago

@editorialbot assign me as editor

editorialbot commented 1 year ago

Assigned! @danielskatz is now the editor

danielskatz commented 1 year ago

👋 @mberacochea, @hseabolt, @Zethson - would any of you be willing to review this JOSS submission?

hseabolt commented 1 year ago

Unfortunately I'm not currently available for this review, sorry!

danielskatz commented 1 year ago

@editorialbot add @wilkinson as reviewer

(Thanks for volunteering to help on this)

editorialbot commented 1 year ago

@wilkinson added to the reviewers list!

abhishektiwari commented 1 year ago

@danielskatz I am open to review workflow related submissions. Feel free to assign me as additional reviewer on this. Seems like an intersting approach to build modular data pipelines.

danielskatz commented 1 year ago

thanks @abhishektiwari - I'll add you, but I'm going to try to find one more reviewer before we start

danielskatz commented 1 year ago

@editorialbot add @abhishektiwari as reviewer

editorialbot commented 1 year ago

@abhishektiwari added to the reviewers list!

Zethson commented 1 year ago

I'll have to politely decline. Currently swamped.

mberacochea commented 1 year ago

Hi all. I can review this one, happy to do so as I'm interested in that tool :).

danielskatz commented 1 year ago

Thanks @mberacochea - I'll add you, and we'll start the review

danielskatz commented 1 year ago

@editorialbot add @mberacochea as reviewer

editorialbot commented 1 year ago

@mberacochea added to the reviewers list!

danielskatz commented 1 year ago

@editorialbot start review

editorialbot commented 1 year ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6089.

rcannood commented 1 year ago

@danielskatz @warrickball @abhishektiwari @mberacochea Thank you all for agreeing to review this paper. I look forward to your feedback!