openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
712 stars 38 forks source link

[REVIEW]: pylattica: a package for prototyping lattice models in 2 chemistry and materials science #6170

Closed editorialbot closed 4 months ago

editorialbot commented 9 months ago

Submitting author: !--author-handle-->@mcgalcode<!--end-author-handle-- (Max C. Gallant) Repository: https://github.com/mcgalcode/pylattica Branch with paper.md (empty if default branch): paper Version: v0.1.3 Editor: !--editor-->@richardjgowers<!--end-editor-- Reviewers: @riesben, @amkrajewski Archive: 10.5281/zenodo.10815119

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/265d902b2934e84005a8bd8fd89aaecb"><img src="https://joss.theoj.org/papers/265d902b2934e84005a8bd8fd89aaecb/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/265d902b2934e84005a8bd8fd89aaecb/status.svg)](https://joss.theoj.org/papers/265d902b2934e84005a8bd8fd89aaecb)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@riesben & @amkrajewski, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @richardjgowers know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

πŸ“ Checklist for @RiesBen

πŸ“ Checklist for @amkrajewski

mcgalcode commented 4 months ago

Hi @Kevin-Mattheus-Moerman, thanks for your suggestions! I've updated the affiliations as you suggested, and added departments as well.

That DOI isn't correct though - it seems to point to a textbook, and my citation is for an issue of Scientific American.

editorialbot commented 4 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

mcgalcode commented 4 months ago

Hey @Kevin-Mattheus-Moerman I think I've addressed everything! Is there any other change I can make for you ?

Kevin-Mattheus-Moerman commented 4 months ago

@mcgalcode apologies for the delay. One final point:

mcgalcode commented 4 months ago

@editorialbot generate pdf

mcgalcode commented 4 months ago

@Kevin-Mattheus-Moerman okay, I've added the heading!

editorialbot commented 4 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Kevin-Mattheus-Moerman commented 4 months ago

@editorialbot accept

editorialbot commented 4 months ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 4 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Gallant given-names: Max C. orcid: "https://orcid.org/0009-0008-4099-6144" - family-names: Persson given-names: Kristin A. orcid: "https://orcid.org/0000-0003-2495-5509" doi: 10.5281/zenodo.10815119 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Gallant given-names: Max C. orcid: "https://orcid.org/0009-0008-4099-6144" - family-names: Persson given-names: Kristin A. orcid: "https://orcid.org/0000-0003-2495-5509" date-published: 2024-05-25 doi: 10.21105/joss.06170 issn: 2475-9066 issue: 97 journal: Journal of Open Source Software publisher: name: Open Journals start: 6170 title: "pylattica: a package for prototyping lattice models in chemistry and materials science" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06170" volume: 9 title: "pylattica: a package for prototyping lattice models in chemistry and materials science" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 4 months ago

🐘🐘🐘 πŸ‘‰ Toot for this paper πŸ‘ˆ 🐘🐘🐘

editorialbot commented 4 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5385
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06170
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! πŸŽ‰πŸŒˆπŸ¦„πŸ’ƒπŸ‘»πŸ€˜

Any issues? Notify your editorial technical team...

Kevin-Mattheus-Moerman commented 4 months ago

@mcgalcode congratulations on this JOSS publication!

@richardjgowers thanks for editing, and a special thank you to the reviewers: @RiesBen and @amkrajewski !!

editorialbot commented 4 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06170/status.svg)](https://doi.org/10.21105/joss.06170)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06170">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06170/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06170/status.svg
   :target: https://doi.org/10.21105/joss.06170

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

mcgalcode commented 4 months ago

@Kevin-Mattheus-Moerman thank you so much, I'm thrilled!

Thank you all @richardjgowers, @RiesBen and @amkrajewski for your help with this, I am very pleased with the result!