openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
712 stars 38 forks source link

[REVIEW]: Taweret: a Python package for Bayesian model mixing #6175

Closed editorialbot closed 3 months ago

editorialbot commented 9 months ago

Submitting author: !--author-handle-->@ominusliticus<!--end-author-handle-- (Kevin Ingles) Repository: https://github.com/bandframework/Taweret.git Branch with paper.md (empty if default branch): joss-submission Version: 1.0.2 Editor: !--editor-->@rkurchin<!--end-editor-- Reviewers: @julienmalard, @gchure Archive: 10.5281/zenodo.11254359

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/43c5f0d033f24fb1c0a1ae00326a169b"><img src="https://joss.theoj.org/papers/43c5f0d033f24fb1c0a1ae00326a169b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/43c5f0d033f24fb1c0a1ae00326a169b/status.svg)](https://joss.theoj.org/papers/43c5f0d033f24fb1c0a1ae00326a169b)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@julienmalard & @gchure, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @rkurchin know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @gchure

📝 Checklist for @julienmalard

rkurchin commented 4 months ago

@ominusliticus, just checking in on the progress of these last few items – we're almost done! :)

ominusliticus commented 4 months ago

Final release version for JOSS publication is: v1.0.2 The zenodo archive is DOI: 10.5281/zenodo.11254359 Authors, ORCIDs, and licenses have been checked Files are currently uploading and I will publish zenodo record once finalized

Regarding the length of the article, we plan to produce a jupyter-book which will be a slightly expanded version of this paper with the notebooks currently in our documentation page moved there and made interactive.

rkurchin commented 4 months ago

@editorialbot set 1.0.2 as version

editorialbot commented 4 months ago

Done! version is now 1.0.2

rkurchin commented 4 months ago

@editorialbot generate pf

editorialbot commented 4 months ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

rkurchin commented 4 months ago

@editorialbot generate pdf

rkurchin commented 4 months ago

@ominusliticus awesome! Could you send a ping here when the Zenodo record is published so I can give it a once-over as well?

editorialbot commented 4 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

ominusliticus commented 4 months ago

@rkurchin just saw there was an upload error, but it is fixed now! The zenodo archive is published! https://zenodo.org/records/11254359

rkurchin commented 4 months ago

@editorialbot set 10.5281/zenodo.11254359 as archive

editorialbot commented 4 months ago

Done! archive is now 10.5281/zenodo.11254359

rkurchin commented 4 months ago

@editorialbot recommend-accept

(note to @openjournals/pe-eics to check this comment re missing DOI's)

editorialbot commented 4 months ago
Attempting dry run of processing paper acceptance...
editorialbot commented 4 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/insr.12243 is OK
- 10.1214/21-BA1287 is OK
- 10.1103/PhysRevC.106.044002 is OK
- 10.1088/1361-6471/abf1df is OK
- 10.1080/00401706.2023.2257765 is OK
- 10.1016/j.jmva.2019.104555 is OK
- 10.1214/17-BA1091 is OK
- 10.1175/MWR3441.1 is OK
- 10.3389/fnhum.2014.00457 is OK
- 10.1016/j.cpc.2021.108168 is OK

MISSING DOIs

- No DOI given, and none found for title: \textttloo: Efficient leave-one-out cross-validati...
- No DOI given, and none found for title: SAMBA: SAndbox for Mixing using Bayesian Analysis
- No DOI given, and none found for title: BANDFramework: an open-source framework for Bayesi...
- No DOI given, and none found for title: Multifaceted study of ultrarelativistic heavy ion ...
- No DOI given, and none found for title: Taweret: a Python package for Bayesian model mixin...
- No DOI given, and none found for title: Open Bayesian Trees project
- No DOI given, and none found for title: BMA: Bayesian model averaging

INVALID DOIs

- None
editorialbot commented 4 months ago

:wave: @openjournals/pe-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5375, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

ominusliticus commented 4 months ago

@rkurchin Am I the one who needs to run the command @editorialbot accept?

danielskatz commented 4 months ago

No, it will be the track editor who will do that.

kyleniemeyer commented 4 months ago

@ominusliticus I will be looking over everything shortly before accepting.

kyleniemeyer commented 4 months ago

@editorialbot accept

editorialbot commented 4 months ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 4 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Ingles given-names: K. orcid: "https://orcid.org/0000-0002-5369-0493" - family-names: Liyanage given-names: D. - family-names: Semposki given-names: A. C. orcid: "https://orcid.org/0000-0003-2354-1523" - family-names: Yannotty given-names: J. C. contact: - family-names: Ingles given-names: K. orcid: "https://orcid.org/0000-0002-5369-0493" doi: 10.5281/zenodo.11254359 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Ingles given-names: K. orcid: "https://orcid.org/0000-0002-5369-0493" - family-names: Liyanage given-names: D. - family-names: Semposki given-names: A. C. orcid: "https://orcid.org/0000-0003-2354-1523" - family-names: Yannotty given-names: J. C. date-published: 2024-05-24 doi: 10.21105/joss.06175 issn: 2475-9066 issue: 97 journal: Journal of Open Source Software publisher: name: Open Journals start: 6175 title: "Taweret: a Python package for Bayesian model mixing" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06175" volume: 9 title: "`Taweret`: a Python package for Bayesian model mixing" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 4 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 4 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5379
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06175
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

kyleniemeyer commented 4 months ago

@openjournals/dev It looks like the <code> tag around the software name in the paper was translated to the webpage for the paper: https://joss.theoj.org/papers/10.21105/joss.06175

Does that require a manual fix? Thanks!

kyleniemeyer commented 4 months ago

Congratulations @ominusliticus on your article's publication in JOSS! Please consider signing up as a reviewer if you haven't already.

Many thanks to @julienmalard and @gchure for reviewing this, and @rkurchin for editing.

(I will keep the review issue open until we resolve that webpage issue.)

ominusliticus commented 4 months ago

Thank you and done! Thank you to everyone for your patience and working with us!

kyleniemeyer commented 3 months ago

@openjournals/dev could we get some help removing the <code> tags around the paper's title?

kyleniemeyer commented 3 months ago

Paper title fixed! https://joss.theoj.org/papers/10.21105/joss.06175

editorialbot commented 3 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06175/status.svg)](https://doi.org/10.21105/joss.06175)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06175">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06175/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06175/status.svg
   :target: https://doi.org/10.21105/joss.06175

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: