search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[REVIEW]: PyProximal - scalable convex optimization in Python #6326

Closed editorialbot closed 8 months ago

editorialbot commented 9 months ago

Submitting author: !--author-handle-->@mrava87<!--end-author-handle-- (Matteo Ravasi) Repository: http://github.com/pylops/pyproximal/ Branch with paper.md (empty if default branch): joss Version: v0.8.0 Editor: !--editor-->@sappelhoff<!--end-editor-- Reviewers: @nirum, @ewu63 Archive: 10.5281/zenodo.10805997

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/c953d2cc2f446d83595cc858baadb15d"><img src="https://joss.theoj.org/papers/c953d2cc2f446d83595cc858baadb15d/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/c953d2cc2f446d83595cc858baadb15d/status.svg)](https://joss.theoj.org/papers/c953d2cc2f446d83595cc858baadb15d)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@nirum & @ewu63, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @sappelhoff know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @ewu63

📝 Checklist for @nirum

editorialbot commented 8 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

sappelhoff commented 8 months ago

@editorialbot recommend-accept

editorialbot commented 8 months ago 
Attempting dry run of processing paper acceptance...
editorialbot commented 8 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.softx.2019.100361 is OK
- 10.1561/2400000003 is OK
- 10.1007/978-1-4419-9569-8_10 is OK
- 10.1561/2200000016 is OK
- 10.1007/s10851-010-0251-1 is OK
- 10.1093/gji/ggab388 is OK
- 10.1109/GlobalSIP.2013.6737048 is OK
- 10.1190/tle42070457.1 is OK
- 10.3997/2214-4609.2022616015 is OK
- 10.1109/tci.2024.3359178 is OK
- 10.3997/2214-4609.2021612003 is OK
- 10.1007/s11081-018-9380-y is OK
- 10.5281/zenodo.4486431 is OK
- 10.1145/2897824.2925875 is OK

MISSING DOIs

- No DOI given, and none found for title: proxalgs
- No DOI given, and none found for title: The Proximity Operator Repository

INVALID DOIs

- None
editorialbot commented 8 months ago

:wave: @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5121, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

sappelhoff commented 8 months ago

@mrava87 great, thanks! Our job is done for now. Let's wait for the editor in chief to do a final check and ship this :-)

mrava87 commented 8 months ago

Great! thanks a lot for guiding me through this @sappelhoff, it has been a pleasure :-)

arfon commented 8 months ago

@editorialbot accept

editorialbot commented 8 months ago 
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 8 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Ravasi given-names: Matteo orcid: "https://orcid.org/0000-0003-0020-2721" - family-names: Örnhag given-names: Marcus Valtonen orcid: "https://orcid.org/0000-0001-8687-227X" - family-names: Luiken given-names: Nick orcid: "https://orcid.org/0000-0003-3307-1748" - family-names: Leblanc given-names: Olivier orcid: "https://orcid.org/0000-0003-3641-1875" - family-names: Uruñuela given-names: Eneko orcid: "https://orcid.org/0000-0001-6849-9088" contact: - family-names: Ravasi given-names: Matteo orcid: "https://orcid.org/0000-0003-0020-2721" doi: 10.5281/zenodo.10805997 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Ravasi given-names: Matteo orcid: "https://orcid.org/0000-0003-0020-2721" - family-names: Örnhag given-names: Marcus Valtonen orcid: "https://orcid.org/0000-0001-8687-227X" - family-names: Luiken given-names: Nick orcid: "https://orcid.org/0000-0003-3307-1748" - family-names: Leblanc given-names: Olivier orcid: "https://orcid.org/0000-0003-3641-1875" - family-names: Uruñuela given-names: Eneko orcid: "https://orcid.org/0000-0001-6849-9088" date-published: 2024-03-13 doi: 10.21105/joss.06326 issn: 2475-9066 issue: 95 journal: Journal of Open Source Software publisher: name: Open Journals start: 6326 title: PyProximal - scalable convex optimization in Python type: article url: "https://joss.theoj.org/papers/10.21105/joss.06326" volume: 9 title: PyProximal - scalable convex optimization in Python ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 8 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 8 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5125
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06326
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

mrava87 commented 8 months ago

@sappelhoff just to confirm that the paper DOI works and everything looks good :)

But I do not seem to be able myself to close this issue (point 2), I guess you can...

Thanks again everyone, @sappelhoff @nirum and @ewu63!

sappelhoff commented 8 months ago

Thanks everyone!

editorialbot commented 8 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06326/status.svg)](https://doi.org/10.21105/joss.06326)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06326">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06326/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06326/status.svg
   :target: https://doi.org/10.21105/joss.06326

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: