[REVIEW]: ZodiPy: A Python package for zodiacal light simulations

editorialbot commented 3 months ago

Submitting author: !--author-handle-->@MetinSa@dfm@dfm<!--end-reviewers-list-- Archive: 10.5281/zenodo.10999612

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/647f3b1f0f8bb215c0a6a8be9f0870ca"><img src="https://joss.theoj.org/papers/647f3b1f0f8bb215c0a6a8be9f0870ca/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/647f3b1f0f8bb215c0a6a8be9f0870ca/status.svg)](https://joss.theoj.org/papers/647f3b1f0f8bb215c0a6a8be9f0870ca)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@dfm, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @dfm know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

@dfm, please create your checklist typing: @editorialbot generate my checklist

editorialbot commented 3 months ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

dfm commented 3 months ago

Cross-linking with pyOpenSci submission here: https://github.com/pyOpenSci/software-submission/issues/161

editorialbot commented 3 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.04 s (1440.6 files/s, 131776.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          36            631            362           3039
Markdown                        11            146              0            455
TeX                              2             14              0            236
YAML                             6             19              9            163
TOML                             1              8              1            112
JavaScript                       1              2              0             17
-------------------------------------------------------------------------------
SUM:                            57            820            372           4022
-------------------------------------------------------------------------------

Commit count by author:

   412  Metin San
     3  hermda02
     2  dependabot[bot]
     1  P. L. Lim

editorialbot commented 3 months ago

Paper file info:

📄 Wordcount for paper.md is 617

✅ The paper includes a Statement of need section

editorialbot commented 3 months ago

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

editorialbot commented 3 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arXiv.2306.17219 is OK
- 10.48550/arXiv.2306.17226 is OK
- 10.1051/0004-6361/201322068 is OK
- 10.1109/TPAMI.2023.3299526 is OK
- 10.1093/pasj/psae016 is OK
- 10.1086/306380 is OK
- 10.1109/MCSE.2011.37 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1051/0004-6361/201321562 is OK
- 10.1051/0004-6361/202244133 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1186/s40623-023-01856-x is OK
- 10.21105/joss.01298 is OK
- 10.1086/427976 is OK

MISSING DOIs

- No DOI given, and none found for title: PyEphem: Astronomical Ephemeris for Python

INVALID DOIs

- None

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

dfm commented 3 months ago

@editorialbot generate pdf

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

dfm commented 3 months ago

@editorialbot set 10.5281/zenodo.10999612 as archive

editorialbot commented 3 months ago

Done! archive is now 10.5281/zenodo.10999612

dfm commented 3 months ago

@editorialbot recomment-accept

editorialbot commented 3 months ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

dfm commented 3 months ago

@editorialbot recommend-accept

editorialbot commented 3 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 3 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arXiv.2306.17219 is OK
- 10.48550/arXiv.2306.17226 is OK
- 10.1051/0004-6361/201322068 is OK
- 10.1109/TPAMI.2023.3299526 is OK
- 10.1093/pasj/psae016 is OK
- 10.1086/306380 is OK
- 10.1109/MCSE.2011.37 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1051/0004-6361/201321562 is OK
- 10.1051/0004-6361/202244133 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1186/s40623-023-01856-x is OK
- 10.21105/joss.01298 is OK
- 10.1086/427976 is OK

MISSING DOIs

- No DOI given, and none found for title: PyEphem: Astronomical Ephemeris for Python

INVALID DOIs

- None

editorialbot commented 3 months ago

:wave: @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5255, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

dfm commented 3 months ago

@editorialbot accept

editorialbot commented 3 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 3 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: San given-names: Metin orcid: "https://orcid.org/0000-0003-4648-8729" doi: 10.5281/zenodo.10999612 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: San given-names: Metin orcid: "https://orcid.org/0000-0003-4648-8729" date-published: 2024-04-20 doi: 10.21105/joss.06648 issn: 2475-9066 issue: 96 journal: Journal of Open Source Software publisher: name: Open Journals start: 6648 title: "ZodiPy: A Python package for zodiacal light simulations" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06648" volume: 9 title: "ZodiPy: A Python package for zodiacal light simulations" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 3 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 3 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5256
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06648
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

dfm commented 3 months ago

@MetinSa – your paper is now accepted and published in JOSS :zap::rocket::boom:

editorialbot commented 3 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06648/status.svg)](https://doi.org/10.21105/joss.06648)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06648">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06648/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06648/status.svg
   :target: https://doi.org/10.21105/joss.06648

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

MetinSa commented 3 months ago

Thank you for the quick review @dfm! 🎉

openjournals / joss-reviews