openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
712 stars 38 forks source link

[PRE REVIEW]: evitaicossa: an R package for anti-associative algebra #7035

Closed editorialbot closed 1 month ago

editorialbot commented 2 months ago

Submitting author: !--author-handle-->@RobinHankin<!--end-author-handle-- (Robin Hankin) Repository: https://github.com/RobinHankin/evitaicossa Branch with paper.md (empty if default branch): Version: 0.0-2 Editor: Pending Reviewers: Pending Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9e970d1c342636a9b37c636b92e5bbf0"><img src="https://joss.theoj.org/papers/9e970d1c342636a9b37c636b92e5bbf0/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9e970d1c342636a9b37c636b92e5bbf0/status.svg)](https://joss.theoj.org/papers/9e970d1c342636a9b37c636b92e5bbf0)

Author instructions

Thanks for submitting your paper to JOSS @RobinHankin. Currently, there isn't a JOSS editor assigned to your paper.

@RobinHankin if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 2 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 2 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.02 s (1479.6 files/s, 177781.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               10            173             13           1046
C++                              2             70             20            829
Markdown                         5             39              0            163
TeX                              3             18              0            154
YAML                             3             18              5             81
Rmd                              2             98            279             68
C/C++ Header                     1             15              1             34
-------------------------------------------------------------------------------
SUM:                            26            431            318           2375
-------------------------------------------------------------------------------

Commit count by author:

    94  robin
    40  RobinHankin
     1  Robin Hankin
editorialbot commented 2 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- No DOI given, and none found for title: Anti-associative algebras

INVALID DOIs

- None
editorialbot commented 2 months ago

Paper file info:

📄 Wordcount for paper.md is 173

✅ The paper includes a Statement of need section

editorialbot commented 2 months ago

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

editorialbot commented 2 months ago

:warning: An error happened when generating the pdf.

danielskatz commented 2 months ago

👋 @RobinHankin - thanks for your submission.

Note that your paper does not compile. Please follow the example paper and note that you can click on the error above to find out more about it. Please feel free to make changes to your .md file, then use the command @editorialbot generate pdf to make a new PDF. editorialbot commands need to be the first entry in a new comment.

Also, your paper is remarkably short, and doesn't really explain to a general (non-mathematician) audience what this software is or why it is needed. It also doesn't have any references, which seems unusual for scientific work. You might want to extend it a bit, perhaps with a bit of what's in the README as well.

In addition, the JOSS editors will evaluate the scope in terms of the effort, once there is a paper that compiles. It appears that the main directory (R) has about 650 lines of code and this seems to have a commit history of a few months, both of which may be issues of scholarly effort (see https://joss.readthedocs.io/en/latest/submitting.html#substantial-scholarly-effort)

RobinHankin commented 2 months ago

@editorialbot generate pdf

editorialbot commented 2 months ago

:warning: An error happened when generating the pdf.

RobinHankin commented 2 months ago

@danielskatz thanks for this. I am currently looking at the compilation issue [I could not figure out how to get the editorialbot to generate the PDF before submission, can you advise?], but in the meantime, the submission is written in R and C with a total of 1678 lines of code, within scope? Also, there is a reference list but perhaps the compilation failure rendered it invisible.

In any event, I will extend paper.md as you suggest.

Best wishes

Robin

danielskatz commented 2 months ago

I think the affiliation part of the .md file needs to be more like the example

affiliations:
 - name: University of Stirling, UK
   index: 1

rather than

affiliations: name "University of Stirling"
danielskatz commented 2 months ago

And I missed the C++ code, so the LOCs might be less of an issue, but the short commit history still might

danielskatz commented 2 months ago

Once the paper does compile, please use the command @editorialbot check references to make sure there are DOIs for everything that should have them

RobinHankin commented 2 months ago

@editorialbot generate pdf

editorialbot commented 2 months ago

:warning: An error happened when generating the pdf.

RobinHankin commented 2 months ago

@editorialbot generate pdf

editorialbot commented 2 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 2 months ago

Five most similar historical JOSS papers:

Ryacas: A computer algebra system in R Submitting author: @mikldk Handling editor: @drvinceknight (Active) Reviewers: @MikeLydeamore, @EduPH Similarity score: 0.5968

datastructures: An R package for organisation and storage of data Submitting author: @dirmeier Handling editor: @karthik (Retired) Reviewers: @fabian-s Similarity score: 0.5901

OApackage: A Python package for generation and analysis of orthogonal arrays, optimal designs and conference designs Submitting author: @eendebakpt Handling editor: @danielskatz (Active) Reviewers: @djmitche, @gsagnol Similarity score: 0.5792

Cadabra2: computer algebra for field theory revisited Submitting author: @kpeeters Handling editor: @danielskatz (Active) Reviewers: @StewMH, @henrik227 Similarity score: 0.5788

The psycho Package: an Efficient and Publishing-Oriented Workflow for Psychological Science Submitting author: @DominiqueMakowski Handling editor: @leeper (Retired) Reviewers: @SachaEpskamp Similarity score: 0.5764

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

danielskatz commented 2 months ago

@editorialbot query scope

As I mentioned previously, due to the relatively short commit history, the editors will now discuss if this submission meets the substantial scholarly effort criterion for review by JOSS. You should hear back in a week or two.

editorialbot commented 2 months ago

Submission flagged for editorial review.

RobinHankin commented 2 months ago

@editorialbot check references

editorialbot commented 2 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- No DOI given, and none found for title: Anti-associative algebras

INVALID DOIs

- None
RobinHankin commented 2 months ago

@editorialbot check references

editorialbot commented 2 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arXiv.2202.10812 is OK

MISSING DOIs

- None

INVALID DOIs

- None
RobinHankin commented 2 months ago

@editorialbot generate pdf

editorialbot commented 2 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 2 months ago

Five most similar historical JOSS papers:

Ryacas: A computer algebra system in R Submitting author: @mikldk Handling editor: @drvinceknight (Active) Reviewers: @MikeLydeamore, @EduPH Similarity score: 0.6705

OApackage: A Python package for generation and analysis of orthogonal arrays, optimal designs and conference designs Submitting author: @eendebakpt Handling editor: @danielskatz (Active) Reviewers: @djmitche, @gsagnol Similarity score: 0.6636

Cadabra2: computer algebra for field theory revisited Submitting author: @kpeeters Handling editor: @danielskatz (Active) Reviewers: @StewMH, @henrik227 Similarity score: 0.6601

TDAstats: R pipeline for computing persistent homology in topological data analysis Submitting author: @rrrlw Handling editor: @leeper (Retired) Reviewers: @corybrunson Similarity score: 0.6529

PySymmPol - Symmetric Polynomials Submitting author: @thraraujo Handling editor: @phibeck (Active) Reviewers: @eliotwrobson, @AnnikaStein Similarity score: 0.6500

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

RobinHankin commented 2 months ago

@editorialbot check references

editorialbot commented 2 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arXiv.2202.10812 is OK
- 10.1007/978-3-031-19293-7 is OK

MISSING DOIs

- 10.1155/5708 may be a valid DOI for title: Algebra
- No DOI given, and none found for title: Calculus on manifolds
- No DOI given, and none found for title: An introduction to nonassociative algebras

INVALID DOIs

- None
RobinHankin commented 2 months ago

@editorialbot generate pdf

editorialbot commented 2 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 2 months ago

Five most similar historical JOSS papers:

Ryacas: A computer algebra system in R Submitting author: @mikldk Handling editor: @drvinceknight (Active) Reviewers: @MikeLydeamore, @EduPH Similarity score: 0.6892

OApackage: A Python package for generation and analysis of orthogonal arrays, optimal designs and conference designs Submitting author: @eendebakpt Handling editor: @danielskatz (Active) Reviewers: @djmitche, @gsagnol Similarity score: 0.6840

Economiccomplexity: Computational Methods for Economic Complexity Submitting author: @pachamaltese Handling editor: @oliviaguest (Active) Reviewers: @JohnCoene, @mpadge Similarity score: 0.6794

PySymmPol - Symmetric Polynomials Submitting author: @thraraujo Handling editor: @phibeck (Active) Reviewers: @eliotwrobson, @AnnikaStein Similarity score: 0.6780

TDAstats: R pipeline for computing persistent homology in topological data analysis Submitting author: @rrrlw Handling editor: @leeper (Retired) Reviewers: @corybrunson Similarity score: 0.6767

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

RobinHankin commented 2 months ago

@editorialbot check references

editorialbot commented 2 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arXiv.2202.10812 is OK
- 10.1007/978-3-031-19293-7 is OK
- 10.48550/arXiv.2303.06062 is OK

MISSING DOIs

- 10.1155/5708 may be a valid DOI for title: Algebra
- No DOI given, and none found for title: Calculus on manifolds
- No DOI given, and none found for title: An introduction to nonassociative algebras
- No DOI given, and none found for title: Normed division algebras with R: introducing the o...

INVALID DOIs

- None
danielskatz commented 2 months ago

@editorialbot generate pdf

editorialbot commented 2 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 2 months ago

Five most similar historical JOSS papers:

Ryacas: A computer algebra system in R Submitting author: @mikldk Handling editor: @drvinceknight (Active) Reviewers: @MikeLydeamore, @EduPH Similarity score: 0.6890

OApackage: A Python package for generation and analysis of orthogonal arrays, optimal designs and conference designs Submitting author: @eendebakpt Handling editor: @danielskatz (Active) Reviewers: @djmitche, @gsagnol Similarity score: 0.6840

Economiccomplexity: Computational Methods for Economic Complexity Submitting author: @pachamaltese Handling editor: @oliviaguest (Active) Reviewers: @JohnCoene, @mpadge Similarity score: 0.6798

PySymmPol - Symmetric Polynomials Submitting author: @thraraujo Handling editor: @phibeck (Active) Reviewers: @eliotwrobson, @AnnikaStein Similarity score: 0.6780

TDAstats: R pipeline for computing persistent homology in topological data analysis Submitting author: @rrrlw Handling editor: @leeper (Retired) Reviewers: @corybrunson Similarity score: 0.6772

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

danielskatz commented 2 months ago

Thanks @RobinHankin - the paper looks good enough to go into review, but let's see what the editors say about the scholarly effort, which should be a week or two...

danielskatz commented 1 month ago

👋 @RobinHankin - I'm sorry to say that after discussion amongst the JOSS editors, we have decided that this submission does not meet the substantial scholarly effort criterion for review by JOSS. Please see https://joss.readthedocs.io/en/latest/submitting.html#other-venues-for-reviewing-and-publishing-software-packages for other suggestions for how you might receive credit for your work.

danielskatz commented 1 month ago

@editorialbot reject

editorialbot commented 1 month ago

Paper rejected.