openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
712 stars 38 forks source link

[PRE REVIEW]: SPECTPSFToolbox: A Python Toolbox for SPECT Point Spread Function Modeling #7067

Closed editorialbot closed 1 month ago

editorialbot commented 1 month ago

Submitting author: !--author-handle-->@lukepolson<!--end-author-handle-- (Lucas Polson) Repository: https://github.com/lukepolson/SPECTPSFToolbox Branch with paper.md (empty if default branch): Version: v0.1.0 Editor: Pending Reviewers: Pending Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/e349e7cdcac119ab43b43f687ad29236"><img src="https://joss.theoj.org/papers/e349e7cdcac119ab43b43f687ad29236/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/e349e7cdcac119ab43b43f687ad29236/status.svg)](https://joss.theoj.org/papers/e349e7cdcac119ab43b43f687ad29236)

Author instructions

Thanks for submitting your paper to JOSS @lukepolson. Currently, there isn't a JOSS editor assigned to your paper.

@lukepolson if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 month ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 month ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.03 s (787.0 files/s, 209301.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Jupyter Notebook                10              0           2971            861
Python                           5            173            472            717
TeX                              1             21              0            208
Markdown                         2             25              0             70
TOML                             1              8              0             40
Bourne Shell                     2              3              2             14
-------------------------------------------------------------------------------
SUM:                            21            230           3445           1910
-------------------------------------------------------------------------------

Commit count by author:

     5  lukepolson
     1  Luke Polson
editorialbot commented 1 month ago

Paper file info:

📄 Wordcount for paper.md is 1648

✅ The paper includes a Statement of need section

editorialbot commented 1 month ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 1 month ago

:warning: An error happened when generating the pdf. Problem with ORCID (0000-0000-0000-0000) for Luke Polson. Invalid ORCID.

editorialbot commented 1 month ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/42.363108 is OK
- 10.1109/42.52985 is OK
- 10.1109/TNS.2002.998681 is OK
- 10.1109/NSSMIC.2006.354345 is OK
- 10.1088/1361-6560/aa6911 is OK
- 10.1088/1361-6560/aadac1 is OK
- 10.1109/TMI.2003.812251 is OK
- 10.1007/978-1-4614-7657-3_19 is OK
- 10.1109/NSS/MIC42677.2020.9507966 is OK
- 10.21037/atm-20-5988 is OK
- 10.1007/s00259-022-06092-1 is OK
- 10.1007/s00259-024-06681-2 is OK

MISSING DOIs

- 10.1097/mnm.0000000000001675 may be a valid DOI for title: Anatomically guided reconstruction improves lesion...
- No DOI given, and none found for title: PyTomography: A Python Library for Quantitative Me...
- No DOI given, and none found for title: Foundations of Image Science
- No DOI given, and none found for title: Targeted α-therapy of metastatic castration-resist...
- No DOI given, and none found for title: Predictors of overall and disease-free survival in...
- No DOI given, and none found for title: First clinical results for PSMA-targeted α-therapy...
- No DOI given, and none found for title: Molecular imaging and biochemical response assessm...

INVALID DOIs

- https://doi.org/10.1016/0169-2607(89)90111-9 is INVALID because of 'https://doi.org/' prefix
Kevin-Mattheus-Moerman commented 1 month ago

@editorialbot query scope

editorialbot commented 1 month ago

Submission flagged for editorial review.

Kevin-Mattheus-Moerman commented 1 month ago

@lukepolson Dear author, thanks for this submission. I am the AEiC on this track and here to help process the initial steps. I have briefly reviewed this submission and the repository. Unfortunately I will need to reject this submission at this point, as it does not conform to our substantial scholarly effort criteria. Below is a list of points which caused me to reject the submission, and which you should address in case you are considering a future re-submission.

Note that the above python projects also show examples of automated testing/continuous integration.

I have not reviewed your paper in detail but I can add the following about the paper:

If you were to address all of the above points we'd welcome a re-submission. Hope this feedback helps.

Kevin-Mattheus-Moerman commented 1 month ago

@editorialbot reject

editorialbot commented 1 month ago

Paper rejected.

lukepolson commented 1 month ago

Hi @Kevin-Mattheus-Moerman , thanks for the in depth comments. I'm currently in the process of updating the repo to conform to these standards. There's not really a whole lot that I can do about the number of lines of code, but I can certainly fix the other issues. Let me know your thoughts.