openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[PRE REVIEW]: dia: An R package for the National Oceanic and Atmospheric Administration dam impact analysis #7397

Open editorialbot opened 5 hours ago

editorialbot commented 5 hours ago

Submitting author: !--author-handle-->@danStich<!--end-author-handle-- (Daniel Stich) Repository: https://github.com/danStich/dia Branch with paper.md (empty if default branch): main Version: v1.0.0 Editor: Pending Reviewers: Pending Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/7d2f12ac96edf4816423d178ad5731db"><img src="https://joss.theoj.org/papers/7d2f12ac96edf4816423d178ad5731db/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/7d2f12ac96edf4816423d178ad5731db/status.svg)](https://joss.theoj.org/papers/7d2f12ac96edf4816423d178ad5731db)

Author instructions

Thanks for submitting your paper to JOSS @danStich. Currently, there isn't a JOSS editor assigned to your paper.

@danStich if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 5 hours ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 5 hours ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.04 s (815.5 files/s, 428018.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CSS                              2              2             18          13339
R                               24            323           1720           1346
CSV                              3              0              0           1030
Markdown                         2             58              0            311
TeX                              1             12              0            128
YAML                             3             10              8             66
-------------------------------------------------------------------------------
SUM:                            35            405           1746          16220
-------------------------------------------------------------------------------

Commit count by author:

    69  danStich
editorialbot commented 5 hours ago

Paper file info:

📄 Wordcount for paper.md is 769

✅ The paper includes a Statement of need section

editorialbot commented 5 hours ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.25923/v67x-kk62 is OK
- 10.1525/bio.2009.59.11.7 is OK
- 10.3389/fmars.2021.734213 is OK
- 10.1093/icesjms/fsv083 is OK
- 10.1139/cjfas-2018-0008 is OK
- 10.21105/joss.01686 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Dam impact analysis model for Atlantic salmon in t...
- No DOI given, and none found for title: National Marine Fisheries Service Endangered Speci...
- No DOI given, and none found for title: dia: Atlantic salmon dam impact analysis (DIA) for...
- No DOI given, and none found for title: shiny: Web application framework for R
- No DOI given, and none found for title: R: A language and environment for statistical comp...
- No DOI given, and none found for title: ggplot2: Elegant graphics for data analysis

❌ MISSING DOIs

- None

❌ INVALID DOIs

- https://doi.org/10.1002/mcf2.10021 is INVALID because of 'https://doi.org/' prefix
editorialbot commented 5 hours ago

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

editorialbot commented 5 hours ago

:warning: An error happened when generating the pdf. Problem with affiliations for Julie Nieland, perhaps the affiliations index need quoting?.

kthyng commented 5 hours ago

👋 @danStich - note that your paper does not compile. Please follow the example paper and note that you can click on the error above to find out more about it.

danStich commented 4 hours ago

@editorialbot generate pdf

I think it may have been an un-indented "index" tag but I quoted the affiliations just in case (they were all single). Checking here.

editorialbot commented 3 hours ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 3 hours ago

Five most similar historical JOSS papers:

stacomiR : a common tool for monitoring fish migration Submitting author: @MarionLegrandLogrami Handling editor: @arfon (Active) Reviewers: @steffilazerte, @boshek Similarity score: 0.7490

fishRman: A Shiny R Dashboard improving Global Fishing Watch data availability Submitting author: @Shyentist Handling editor: @KristinaRiemer (Retired) Reviewers: @jules32, @HeatherWelch Similarity score: 0.7473

Reference Point Calculator (RPC): A Shiny app for exploration of limit reference points for fisheries management Submitting author: @quang-huynh Handling editor: @graciellehigino (Retired) Reviewers: @ivnols, @katherinehebert Similarity score: 0.7337

nsink: An R package for flow path nitrogen removal estimation Submitting author: @jhollist Handling editor: @crvernon (Active) Reviewers: @jmp75, @ldecicco-USGS, @jmp75 Similarity score: 0.7325

mmrefpoints: Projecting long-term marine mammal abundance with bycatch Submitting author: @mcsiple Handling editor: @fboehm (Active) Reviewers: @ha0ye, @tbrown122387 Similarity score: 0.7275

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

danStich commented 3 hours ago

Hi @kthyng, I think the changes fixed the compilation problem.