openlcb / documents

The OpenLCB specification: standards, recommended practices and other documentation.
3 stars 7 forks source link

Memory Config: get Event ID reply #133

Closed balazsracz closed 4 months ago

balazsracz commented 4 months ago

In #102 we noted that the number of event IDs requested in three bits is 0-7. We forgot to update the text in the Get Event ID reply. That oner still says 1-8 events are returned when correctly it is 0-7.

bobjacobsen commented 4 months ago

Can we fix this with a PR to standards/MemoryConfigurationS.* and the .txt file? or do we need to go through /drafts/ to get the proper history? Happy to do that 2nd thing if it's really needed.

balazsracz commented 4 months ago

We can edit in place in the standards directory, but this will not update the changes/xxx-date.pdf file. It is not super useful to create a new file with a different date and only one line of change.

I see a few options: 1) punt. Take care of this whenever we update the standards next time. This is why I filed the issue, so that we don't forget. 2) Update the changes in a bit of a roundabout way:

bobjacobsen commented 4 months ago

PR #135 is your method (2) above. But note that the diffs in that PR are not what I would have expected. They look like they create the right final state, but they seem to not take into effect the previous adopted docs.