search

openlegend / core-rules

Source text / code for Open Legend RPG
http://www.openlegendrpg.com/
Other
90 stars 56 forks source link

Print Edition Diff (Change) Tracking [DO NOT MERGE] #425

Open brianfeister opened 7 years ago

brianfeister commented 7 years ago

Hey Everyone!

Really grateful for the past editing and proofreading contributions of @ucffool @oconnor0 @istabosz @jcte02 @LordRyst @Hassurunous @raihje @Cryogenic6891!

Can I make a special request for all of you to watch this "Pull Request" carefully? I could really use help catching errors as I begin to really thrash the text. We won't actually be merging this in the main "branch", but it will serve as a visual differentiator on this page over here. Make sure to click "Load Diff" because many of them are too long to be displayed by default. Of the changes I'm making as I produce the final print text. Some of them will be weird things I do to massage the format to accomodate the visual layout, others will be proofreading errors that I find, and still others will be general edits (for example, my tweak to convert that "Battle Mage" archetype to be purely cold-based attacks rather than other elemental types).

ucffool commented 7 years ago

Just a heads-up, I'm sorry I've been unable to look over anything here. I want to help, but my plate is pretty full right now and I just can't. Excited for the result and glad others have been able to step up.

brianfeister commented 7 years ago

Thanks @ucffool, appreciate all you do! 💖

raihje commented 7 years ago

I have a full time work right now with asphalt, but I'll definitely get on this for a few hours each evening.

brianfeister commented 7 years ago

@oconnor0 -- SUPER appreciate the detective work! Any way I could convince you to delve deeper and figure out which specific commit may have caused the regressions?

I'm guessing it was this one?

https://github.com/openlegend/core-rules/commit/f6784480cb069b32b22bad31b858c4d7339f15ab

If so, might be best to just review that PR by itself and comment on where the changes caused regression

oconnor0 commented 7 years ago

@brianfeister Yes, it was that one. I added comments on all the chunks that look like regressions to me at https://github.com/openlegend/core-rules/commit/f6784480cb069b32b22bad31b858c4d7339f15ab