openlibhums / janeway

A web-based platform for publishing journals, preprints, conference proceedings, and books
https://janeway.systems/
GNU Affero General Public License v3.0
177 stars 65 forks source link

Table A11y updates #4055

Open StephDriver opened 8 months ago

StephDriver commented 8 months ago

From #4194 the following issues have been identified:

Part of the problem here is that JATS allows for inaccessible tables to be specified, thus user content will not always produce accessible tables. The row/column headings should be specified in the JATS and then picked up so if it is not correct there, it won't be correct on the page either.

Therefore we should -

StephDriver commented 5 months ago

from Screen reader testing (#4194):

StephDriver commented 5 months ago

https://jats4r.niso.org/accessibility/ JATS table a11y

StephDriver commented 3 months ago

I have started going through the codebase to work out what tables we have and what kind of updates might be needed. I think for the majority, I have the information needed to make updates, so I'd like to move this to Dev Ready and continue working on it there - might as well make changes as I review rather than report my findings only to have to go through them all again to make updates. It is possible some tables will be missed, but this should address the majority, and any outliers could be picked up later as individual fixes.

For info:

I have found 211 tables that need reviews.

Having taking an initial look at the first 24 tables:

From this I believe that even if I only fix the obvious stuff, it would make a big difference.

StephDriver commented 2 weeks ago

Working on tables within themes directory only, and using W3C Tables Tutorial for guidance.

StephDriver commented 1 week ago

templates outside the clean theme that include tables (to investigate): (see https://github.com/openlibhums/janeway/issues/4215#issuecomment-2483302101 for how this list was generated)

StephDriver commented 1 week ago

templates outside the clean theme that include tables (to investigate)

👉 no tables found in templates included from outside the theme directory..