search

openlilylib / lilypond-export

LilyPond export API to write Humdrum, MusicXML and more
GNU General Public License v3.0
22 stars 8 forks source link

Catch up Paul's branch to Alex's recent changes #11

Closed rshura closed 5 years ago

rshura commented 5 years ago

This is the merge of Paul's code with the recent changes (slurs and chord articulations). Paul's code is carried forward, plus the new code from Alex uses sxml now as well.

jpvoigt commented 5 years ago

I skimmed this code and it looks OK to me. Thought it shows merge conflicts?

And one thing to reconsider is the use and the naming of functions like writetag or writetimemod. They where introduced to actually write out some XML text. Now they are used to build the sxml list-tree. One might call it insignificant, but IMO it helps others reading this code if it is called something like sxml:timemod or in the case of a simple tag left out - instead of (writetag tag) just (list tag).

rshura commented 5 years ago

Thank you both for your comments!

@PaulMorris I made all the changes you suggested.

@jpvoigt I agree we should rename the writefoo functions now. I haven't done it in this PR, let me know what's the good option would be. Thanks!