search

openlvc / disco

Java library for Distributed Interactive Simulation
11 stars 3 forks source link

Update crypto system enumeration #49

Closed jarrodgreene closed 3 years ago

jarrodgreene commented 3 years ago

More cyrpto systems have previously been added to CNR, but they hadn't been properly added here, causing those systems to not be detected properly.

Fixes: CNR-2000

timpokorny commented 3 years ago

Ack.

The only thing I think we need to look at here is the changes to the FOM. We can't change the FOM because it's a standard document, so it should remain as defined by the standard.

I'll have to go and look to see if there is a newer version of the RPR FOM that includes these values in the enumerations. I'll have a look now.

timpokorny commented 3 years ago

OK, unfortunately there is NOT an updated version for RPR2, and RPR3 is not done yet.

I think we can implement this change and it'll be OK. Enumerations are just passed around as uints, so it shouldn't be a problem. But, I think we do need drop the FOM change. That way we're not changing the standard documents. We'll just quietly happily serialize/deserialize the values under the hood.

Can I get you to modify the commit (can just update it and then force push so that it stays as one commit)?

jarrodgreene commented 3 years ago

Yep ok done