search

openlvc / disco

Java library for Distributed Interactive Simulation
11 stars 3 forks source link

Update logging to stop overriding jvm-wide config #61

Closed jarrodgreene closed 1 year ago

jarrodgreene commented 1 year ago

The previous update to logging was causing configuration changes across the jvm. E.g. if configured to warn level, all loggers were being set to warn, not just the DISCO ones. This is now more in line with previous behaviour, but without the deprecated methods.

Fixes: CNR-2127

jarrodgreene commented 1 year ago

@timpokorny I've reverted your last changes the Log4jConfiguration, and added back things that looked relevant. Those changes were overriding logging settings set in CNR, so e.g. because for CNR-Server it sets Disco logging to WARN and doesn't just give Disco its logger, Server was getting its loggers set to WARN as well. I'm assuming that you only updated it to deal with the deprecation warnings, which I've done with something more in line with what was there, so let me know if that wasn't the case.

timpokorny commented 1 year ago

Approving and merging this. I am not sure why I made all the logging changes. I recall fighting through some Log4j deprecations somewhere, but, when I load this branch up in Eclipse it thinks everything is good, so... YOLO?