Fix UTC timezone issue in Meteoview2

Shrhawk commented 1 year ago

Checklist:

[ ] All tests are passing
[ ] I have added any necessary documentation and/or release notes
[ ] I have followed the commit message guidelines and the "before submitting a pull request" guidelines
[ ] If I introduced (or abolished) any third-party library, I will write a short paragraph in this PR according to the guidelines
[ ] I have removed all obsoleted code

Shrhawk commented 1 year ago

@aptiko ping, also check the messages

aptiko commented 1 year ago

This is not the right way to fix it. The unit tests were actually correct, because the telemetry.data_timezone is set by the tests to Europe/Athens, meaning it should be converted from that one to UTC, and the station.display_timezone is set to Etc/GMT-2, which is the same thing for winter, so when retrieved and printed, you get the same result as the value received from the logger.

I think that the main code is also correct and that #503 is invalid and everything works as it's supposed to work, so I'm going to go ahead and close both this and #503. If I'm wrong and there is a problem after all, we'll certainly discover it.

openmeteo / enhydris

Fix UTC timezone issue in Meteoview2 #511