search

openmobilemaps / maps-core

The lightweight and modern Map SDK for Android and iOS
https://openmobilemaps.io
Mozilla Public License 2.0
163 stars 17 forks source link

Bugfix/multi buffers #653

Closed maerki closed 2 weeks ago

maerki commented 3 weeks ago

Summary by CodeRabbit

coderabbitai[bot] commented 3 weeks ago

Walkthrough

The changes introduced in this pull request primarily enhance the functionality and structure of various classes related to map rendering and camera management. Key additions include new methods for retrieving scaling factors in multiple interfaces, improved buffer management in rendering classes, and enhancements to error handling and thread safety. The modifications span across multiple files, including both Java and C++ implementations, as well as Swift files, reflecting a comprehensive update to the rendering pipeline and camera interface.

Changes

File Path Change Summary
bridging/android/java/io/openmobilemaps/mapscore/shared/map/MapCameraInterface.kt Added abstract fun getScalingFactor(): Double in MapCameraInterface; implemented in CppProxy.
bridging/android/jni/map/NativeMapCameraInterface.cpp Added CJNIEXPORT jdouble JNICALL Java_io_openmobilemaps_mapscore_shared_map_MapCameraInterface_00024CppProxy_native_1getScalingFactor(JNIEnv* jniEnv, jobject /*this*/, jlong nativeRef) method.
bridging/ios/MCMapCameraInterface+Private.mm Added - (double)getScalingFactor method.
bridging/ios/MCMapCameraInterface.h Added - (double)getScalingFactor; method.
djinni/map/core.djinni Added get_scaling_factor() : f64 method.
ios/graphics/Model/BaseGraphicsObject.swift Updated originOffsetBuffer to originOffsetBuffers; added vpMatrixBuffers and mMatrixBuffers; updated method signatures for clarity.
ios/graphics/Model/Icosahedron/Icosahedron.swift Updated render methods for vertex matrix handling using new buffer management.
ios/graphics/Model/Line/LineGroup2d.swift Updated buffer handling and error checking in render and setLines methods.
ios/graphics/Model/MultiBuffer.swift Added MultiBuffer<DataType> struct and methods for managing multiple Metal buffers.
ios/graphics/Model/Polygon/Polygon2d.swift Added mMatrixBuffers; updated rendering methods for new buffer management.
ios/graphics/Model/Polygon/PolygonGroup2d.swift Updated render and setVertices methods for improved buffer management.
ios/graphics/Model/Polygon/PolygonPatternGroup2d.swift Updated render and setVertices methods for new buffer handling.
ios/graphics/Model/Quad/Quad2d.swift Added mMatrixBuffers; updated rendering logic for vertex data management.
ios/graphics/Model/Quad/Quad2dInstanced.swift Replaced originBuffer with originBuffers; added mMatrixBuffers.
ios/graphics/Model/Quad/Quad2dStretchedInstanced.swift Introduced new buffer handling for vertex matrices and origin offsets.
ios/graphics/Model/Text/Text.swift Introduced vpMatrixBuffer for vertex matrix data management; updated error handling.
ios/graphics/Model/Text/TextInstanced.swift Replaced individual buffers with MultiBuffer instances for better management.
ios/graphics/RenderingContext.swift Added public static let bufferCount = 3 and private(set) var currentBufferIndex = 0; added public func beginFrame() method.
ios/maps/MCMapView.swift Added private var renderSemaphore = DispatchSemaphore(value: 3) for rendering synchronization.
shared/public/MapCameraInterface.h Added virtual double getScalingFactor() = 0; method.
shared/public/Tiled2dMapSourceImpl.h Reformatted method signatures for readability; no logic changes.
shared/src/map/camera/MapCamera3d.cpp Improved organization and refined logic for camera movements; added coordinateConversionHelper.
shared/src/map/camera/MapCamera3d.h Added void updateMatrices(); adjusted method signatures for consistency.
shared/src/map/layers/tiled/vector/symbol/Tiled2dMapVectorSourceSymbolDataManager.cpp Updated scaleFactor calculations and refined layer update logic.

Poem

In the world of maps, we hop and play,
With scaling factors brightening the way.
Buffers are managed, errors are tamed,
In our rendering realm, nothing's the same!
Hooray for the changes, let’s leap and cheer,
For every new feature brings us more near! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.