openpassport-org / openpassport

Generate privacy-preserving ID proofs
https://openpassport.app
346 stars 59 forks source link

Try with more passports and improve reading #73

Open 0xturboblitz opened 8 months ago

0xturboblitz commented 8 months ago

The libraries we use for NFC reading work well in some cases but sometimes fail. One example of error I had recently with a passport on iOS is the following:

2024-03-04 21:39:27.2100 - Starting Password Authenticated Connection Establishment (PACE)
2024-03-04 21:39:27.2100 - Performing PACE with id-PACE-DH-GM-3DES-CBC-CBC
2024-03-04 21:39:38.2310 - PACE Failed - falling back to BAC
2024-03-04 21:39:38.2620 - Error reading tag: sw1 - 0x68, sw2 - 0x83
2024-03-04 21:39:38.2630 - reason: Last command of the chain expected

Trying with new passports and solving those bugs would really help. As with other issues, we will reward generously anyone helping on that, just DM us.

Android

Main libs are: https://github.com/tananaev/passport-reader https://github.com/jllarraz/AndroidPassportReader

We use the first for nfc and the second for OCR. The second also has nfc, might wanna look how it differs.

Rarimo here

iOS

We use: https://github.com/AndyQ/NFCPassportReader

For OCR I sometimes get the wrong 3 inputs

princeibs commented 8 months ago

Hi @0xturboblitz, this seems like an interesting fix. I would like to jump on it

0xturboblitz commented 8 months ago

please go ahead!

princeibs commented 8 months ago

Hi @0xturboblitz, I wanted to DM you concerning some assistance I need for this project, but i realised that your telegram handle is not in your OnlyDust profile. Please can you help me with other means I can reach out?

0xturboblitz commented 8 months ago

You can DM me at @FlorentTavernier on telegram

danielcdz commented 6 months ago

Hello! @0xturboblitz, I would like to help with this one!

Adecom16 commented 6 months ago

Hi @0xturboblitz i would love to work on this, can i ??

0xturboblitz commented 6 months ago

Please explain how you would tackle it first!

Adecom16 commented 6 months ago

Please explain how you would tackle it first!

I am Adeoluwa a smart contract developer. The possible solution to tackle this is:

danielcdz commented 6 months ago

Please explain how you would tackle it first!

I will tackle this by:

RJMadrigal commented 5 months ago

Hi! I would like to help with this issue.

LazarusAA commented 3 months ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hi @0xturboblitz, I'm a software developer interested in gaining experience with projects like this. This seems like a fun issue to tackle, and I feel confident I can find the cause of this bugs and fix them.

How I plan on tackling this issue

I would start off by testing different passports to familiarize with the errors and get an idea of what might be the issue. Then Id tackle them one by one making sure that everything works as it should.

I would appreciate the opportunity.

CrimsonKarma44 commented 3 months ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have 3 years of experience in backend programming in golang and python framework (django, flask)

How I plan on tackling this issue

i will test the service with multiple passports to help with accuracy of the reading

Damilola145 commented 3 months ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hi,I'm a software developer with 3 years of experience.I have a desire to always make software solutiions available when the need arises.

How I plan on tackling this issue

I would examine with different passports and observe the test,and implement the best solutions based from the results drawn from the test