openpoke / decidim-module-reporting-proposals

A new component for Decidim based on Proposals focus on reporting geolocated actuations in a city
GNU Affero General Public License v3.0
6 stars 5 forks source link

Additional button for show proposal page #39

Closed antopalidi closed 1 year ago

antopalidi commented 1 year ago

fix #38

screen
codecov-commenter commented 1 year ago

Codecov Report

Base: 79.55% // Head: 97.76% // Increases project coverage by +18.20% :tada:

Coverage data is based on head (cad58a0) compared to base (d3bba05). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #39 +/- ## =========================================== + Coverage 79.55% 97.76% +18.20% =========================================== Files 39 39 Lines 670 670 =========================================== + Hits 533 655 +122 + Misses 137 15 -122 ``` | [Impacted Files](https://codecov.io/gh/openpoke/decidim-module-reporting-proposals/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpoke) | Coverage Δ | | |---|---|---| | [...rticipatory\_space\_role\_config/valuator\_override.rb](https://codecov.io/gh/openpoke/decidim-module-reporting-proposals/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpoke#diff-YXBwL21vZGVscy9jb25jZXJucy9kZWNpZGltL3JlcG9ydGluZ19wcm9wb3NhbHMvcGFydGljaXBhdG9yeV9zcGFjZV9yb2xlX2NvbmZpZy92YWx1YXRvcl9vdmVycmlkZS5yYg==) | `100.00% <0.00%> (+12.50%)` | :arrow_up: | | [...n/proposal\_answer\_templates\_controller\_override.rb](https://codecov.io/gh/openpoke/decidim-module-reporting-proposals/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpoke#diff-YXBwL2NvbnRyb2xsZXJzL2NvbmNlcm5zL2RlY2lkaW0vcmVwb3J0aW5nX3Byb3Bvc2Fscy9hZG1pbi9wcm9wb3NhbF9hbnN3ZXJfdGVtcGxhdGVzX2NvbnRyb2xsZXJfb3ZlcnJpZGUucmI=) | `100.00% <0.00%> (+12.50%)` | :arrow_up: | | [...forms/decidim/reporting\_proposals/proposal\_form.rb](https://codecov.io/gh/openpoke/decidim-module-reporting-proposals/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpoke#diff-YXBwL2Zvcm1zL2RlY2lkaW0vcmVwb3J0aW5nX3Byb3Bvc2Fscy9wcm9wb3NhbF9mb3JtLnJi) | `100.00% <0.00%> (+17.64%)` | :arrow_up: | | [...g\_proposals/admin/proposals\_controller\_override.rb](https://codecov.io/gh/openpoke/decidim-module-reporting-proposals/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpoke#diff-YXBwL2NvbnRyb2xsZXJzL2NvbmNlcm5zL2RlY2lkaW0vcmVwb3J0aW5nX3Byb3Bvc2Fscy9hZG1pbi9wcm9wb3NhbHNfY29udHJvbGxlcl9vdmVycmlkZS5yYg==) | `86.66% <0.00%> (+20.00%)` | :arrow_up: | | [...rting\_proposals/admin/proposals\_helper\_override.rb](https://codecov.io/gh/openpoke/decidim-module-reporting-proposals/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpoke#diff-YXBwL2hlbHBlcnMvY29uY2VybnMvZGVjaWRpbS9yZXBvcnRpbmdfcHJvcG9zYWxzL2FkbWluL3Byb3Bvc2Fsc19oZWxwZXJfb3ZlcnJpZGUucmI=) | `93.54% <0.00%> (+38.70%)` | :arrow_up: | | [...porting\_proposals/proposals\_controller\_override.rb](https://codecov.io/gh/openpoke/decidim-module-reporting-proposals/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpoke#diff-YXBwL2NvbnRyb2xsZXJzL2NvbmNlcm5zL2RlY2lkaW0vcmVwb3J0aW5nX3Byb3Bvc2Fscy9wcm9wb3NhbHNfY29udHJvbGxlcl9vdmVycmlkZS5yYg==) | `87.23% <0.00%> (+48.93%)` | :arrow_up: | | [...cidim/reporting\_proposals/form\_builder\_override.rb](https://codecov.io/gh/openpoke/decidim-module-reporting-proposals/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpoke#diff-YXBwL2Zvcm1zL2NvbmNlcm5zL2RlY2lkaW0vcmVwb3J0aW5nX3Byb3Bvc2Fscy9mb3JtX2J1aWxkZXJfb3ZlcnJpZGUucmI=) | `95.65% <0.00%> (+52.17%)` | :arrow_up: | | [...ecidim/reporting\_proposals/map\_builder\_override.rb](https://codecov.io/gh/openpoke/decidim-module-reporting-proposals/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpoke#diff-YXBwL2Zvcm1zL2NvbmNlcm5zL2RlY2lkaW0vcmVwb3J0aW5nX3Byb3Bvc2Fscy9tYXBfYnVpbGRlcl9vdmVycmlkZS5yYg==) | `100.00% <0.00%> (+54.16%)` | :arrow_up: | | [...osals/needs\_proposal\_extra\_validations\_snippets.rb](https://codecov.io/gh/openpoke/decidim-module-reporting-proposals/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpoke#diff-YXBwL2NvbnRyb2xsZXJzL2NvbmNlcm5zL2RlY2lkaW0vcmVwb3J0aW5nX3Byb3Bvc2Fscy9uZWVkc19wcm9wb3NhbF9leHRyYV92YWxpZGF0aW9uc19zbmlwcGV0cy5yYg==) | `100.00% <0.00%> (+55.00%)` | :arrow_up: | | [...reporting\_proposals/admin/needs\_header\_snippets.rb](https://codecov.io/gh/openpoke/decidim-module-reporting-proposals/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpoke#diff-YXBwL2NvbnRyb2xsZXJzL2NvbmNlcm5zL2RlY2lkaW0vcmVwb3J0aW5nX3Byb3Bvc2Fscy9hZG1pbi9uZWVkc19oZWFkZXJfc25pcHBldHMucmI=) | `100.00% <0.00%> (+57.69%)` | :arrow_up: | | ... and [2 more](https://codecov.io/gh/openpoke/decidim-module-reporting-proposals/pull/39?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpoke) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpoke). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpoke)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

antopalidi commented 1 year ago

Also, I'd would like to remove the checkbox: image

Let's show the button if there's text and link and just not show if there's not.

I found it unnecessary to create a checkbox for each custom button. So I left one for both buttons first. Now I added a second checkbox.