search

openpreserve / jhove

File validation and characterisation.
http://jhove.openpreservation.org
Other
171 stars 79 forks source link

Bump EPUBCheck in extension modules from 4.2.2 to 4.2.6 #650

Closed karenhanson closed 2 years ago

karenhanson commented 4 years ago

Not sure if dependabot will catch this, so submitting a manual PR for the latest version of EPUBCheck.

Two changes to EPUBCheck since 4.2.2 cause some tests to fail:

  1. A change to the error messages returned for validation of a non-EPUB: w3c/epubcheck#1134 The solution to fixing the test was simply to change the expected message count.
  2. A downgrade of the "encrypted file" message to INFO: w3c/epubcheck#1136 This led to a decision point. The original implementation of the JHOVE EPUB module did not include INFO messages generated by EPUBCheck in the JHOVE report, but looking at the kinds of messages that might be listed as INFO messages I thought it might be useful to include them. I have added INFO messages to the report in this PR, but can roll back if this seems inappropriate. For reference, severity levels are defined here. The message values are here.

Update 4/14/2021: since the original PR, EPUBCheck 4.2.5 is now available, and so I've pushed a commit for that. No changes to the code were required, but the new checker identified an issue in one of the test files - this line in the OPF: <meta refines="title" property="title-type"> needed to be using the fragment reference: <meta refines="#title" property="title-type">

Update 1/26/2022: EPUBCheck 4.2.6 is now available and so I've incremented the version again. No additional changes required to the code as far as I can tell - tests still pass.

codecov[bot] commented 4 years ago

Codecov Report

Merging #650 (a8baf72) into integration (9c17f89) will not change coverage. The diff coverage is n/a.

@@              Coverage Diff               @@
##             integration     #650   +/-   ##
==============================================
  Coverage          45.63%   45.63%           
  Complexity          1047     1047           
==============================================
  Files                 57       57           
  Lines               9146     9146           
  Branches            1683     1683           
==============================================
  Hits                4174     4174           
  Misses              4422     4422           
  Partials             550      550

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e412867...a8baf72. Read the comment docs.