search

openpreserve / jhove

File validation and characterisation.
http://jhove.openpreservation.org
Other
171 stars 79 forks source link

gif-hul: use ModuleBase#readUnsignedByte to read global color table #663

Closed trimbe closed 2 years ago

trimbe commented 3 years ago

Previously this used the method on the DataInputStream which prevented _nByte from being incremented, causing offsets reported by messages to be offset by the size of the global color table if they occurred after it.

codecov[bot] commented 3 years ago

Codecov Report

Merging #663 (52218d6) into integration (fe37ef8) will not change coverage. The diff coverage is n/a.

@@              Coverage Diff               @@
##             integration     #663   +/-   ##
==============================================
  Coverage          45.75%   45.75%           
  Complexity          1051     1051           
==============================================
  Files                 57       57           
  Lines               9145     9145           
  Branches            1684     1684           
==============================================
  Hits                4184     4184           
  Misses              4405     4405           
  Partials             556      556

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8feb080...52218d6. Read the comment docs.