search

openpreserve / jhove

File validation and characterisation.
http://jhove.openpreservation.org
Other
171 stars 79 forks source link

Problem Filter as indirect object solved, fixes #672 #749

Closed samalloing closed 1 year ago

samalloing commented 2 years ago

Hi @carlwilson ,

For this pull request I updated some constructors. Can you check if it is according to your standards?

Thanks

Sam

samalloing commented 1 year ago

Hi @carlwilson

Yes, I thought you wouldn't be happy with it :-) But I looked long for a solution and I hope the problem can be fixed. If you have a better solution that solves the problem that would be great of course. But is there an issue to solve the cyclic dependencies in the module, so we can work on this and solve it gradually.

Sam

carlwilson commented 1 year ago

As I said, it's not an issue of your making. If I'd seen an easier route I'd have gone for it. I'm coming round to the idea of merging this for now as it tracks a real dependency regardless of how ugly it is.