openpreserve / jhove

File validation and characterisation.
http://jhove.openpreservation.org
Other
171 stars 79 forks source link

Name and LastMod in Annotation can be encrypted #781

Closed samalloing closed 1 year ago

samalloing commented 2 years ago

Hi @carlwilson

Again a small pull request when a file is encrypted the information in Name and LastModified of Annotations can also be encrypted. This shows that the information can be encrypted in these field. This is also what happens in the Contents field

Sam

codecov[bot] commented 2 years ago

Codecov Report

Base: 46.22% // Head: 29.18% // Decreases project coverage by -17.05% :warning:

Coverage data is based on head (9c1aa37) compared to base (a7e8dff). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## integration #781 +/- ## ================================================== - Coverage 46.22% 29.18% -17.05% + Complexity 1056 597 -459 ================================================== Files 57 57 Lines 9057 9057 Branches 1607 1607 ================================================== - Hits 4187 2643 -1544 - Misses 4330 6033 +1703 + Partials 540 381 -159 ``` | [Impacted Files](https://codecov.io/gh/openpreserve/jhove/pull/781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpreserve) | Coverage Δ | | |---|---|---| | [...n/java/edu/harvard/hul/ois/jhove/DocumentType.java](https://codecov.io/gh/openpreserve/jhove/pull/781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpreserve#diff-amhvdmUtY29yZS9zcmMvbWFpbi9qYXZhL2VkdS9oYXJ2YXJkL2h1bC9vaXMvamhvdmUvRG9jdW1lbnRUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [.../java/edu/harvard/hul/ois/jhove/SignatureType.java](https://codecov.io/gh/openpreserve/jhove/pull/781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpreserve#diff-amhvdmUtY29yZS9zcmMvbWFpbi9qYXZhL2VkdS9oYXJ2YXJkL2h1bC9vaXMvamhvdmUvU2lnbmF0dXJlVHlwZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [...java/edu/harvard/hul/ois/jhove/IdentifierType.java](https://codecov.io/gh/openpreserve/jhove/pull/781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpreserve#diff-amhvdmUtY29yZS9zcmMvbWFpbi9qYXZhL2VkdS9oYXJ2YXJkL2h1bC9vaXMvamhvdmUvSWRlbnRpZmllclR5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [...va/edu/harvard/hul/ois/jhove/SignatureUseType.java](https://codecov.io/gh/openpreserve/jhove/pull/781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpreserve#diff-amhvdmUtY29yZS9zcmMvbWFpbi9qYXZhL2VkdS9oYXJ2YXJkL2h1bC9vaXMvamhvdmUvU2lnbmF0dXJlVXNlVHlwZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [...main/java/edu/harvard/hul/ois/jhove/Signature.java](https://codecov.io/gh/openpreserve/jhove/pull/781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpreserve#diff-amhvdmUtY29yZS9zcmMvbWFpbi9qYXZhL2VkdS9oYXJ2YXJkL2h1bC9vaXMvamhvdmUvU2lnbmF0dXJlLmphdmE=) | `0.00% <0.00%> (-97.06%)` | :arrow_down: | | [...main/java/edu/harvard/hul/ois/jhove/XMPSource.java](https://codecov.io/gh/openpreserve/jhove/pull/781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpreserve#diff-amhvdmUtY29yZS9zcmMvbWFpbi9qYXZhL2VkdS9oYXJ2YXJkL2h1bC9vaXMvamhvdmUvWE1QU291cmNlLmphdmE=) | `0.00% <0.00%> (-91.18%)` | :arrow_down: | | [.../main/java/edu/harvard/hul/ois/jhove/Document.java](https://codecov.io/gh/openpreserve/jhove/pull/781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpreserve#diff-amhvdmUtY29yZS9zcmMvbWFpbi9qYXZhL2VkdS9oYXJ2YXJkL2h1bC9vaXMvamhvdmUvRG9jdW1lbnQuamF2YQ==) | `0.00% <0.00%> (-87.88%)` | :arrow_down: | | [...c/main/java/edu/harvard/hul/ois/jhove/Message.java](https://codecov.io/gh/openpreserve/jhove/pull/781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpreserve#diff-amhvdmUtY29yZS9zcmMvbWFpbi9qYXZhL2VkdS9oYXJ2YXJkL2h1bC9vaXMvamhvdmUvTWVzc2FnZS5qYXZh) | `0.00% <0.00%> (-72.00%)` | :arrow_down: | | [...ain/java/edu/harvard/hul/ois/jhove/Identifier.java](https://codecov.io/gh/openpreserve/jhove/pull/781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpreserve#diff-amhvdmUtY29yZS9zcmMvbWFpbi9qYXZhL2VkdS9oYXJ2YXJkL2h1bC9vaXMvamhvdmUvSWRlbnRpZmllci5qYXZh) | `0.00% <0.00%> (-70.00%)` | :arrow_down: | | [...edu/harvard/hul/ois/jhove/ChecksumInputStream.java](https://codecov.io/gh/openpreserve/jhove/pull/781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpreserve#diff-amhvdmUtY29yZS9zcmMvbWFpbi9qYXZhL2VkdS9oYXJ2YXJkL2h1bC9vaXMvamhvdmUvQ2hlY2tzdW1JbnB1dFN0cmVhbS5qYXZh) | `0.00% <0.00%> (-68.43%)` | :arrow_down: | | ... and [24 more](https://codecov.io/gh/openpreserve/jhove/pull/781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpreserve) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpreserve). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpreserve)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

samalloing commented 2 years ago

Hi @carlwilson

I updated this pull request, because also CreationDate and ModDate are encrypted is this file. The information is now shown but as encrypted instead of omitted.

Hopefully this didn't mess up my pull request. I 'm also trying to improve my git skills ;-)

Sam

carlwilson commented 1 year ago

This one seems to have been committed already as part of the other merges so I can close it safely, thank @samalloing