search

openresty / srcache-nginx-module

Transparent subrequest-based caching layout for arbitrary nginx locations.
http://wiki.nginx.org/NginxHttpSRCacheModule
475 stars 105 forks source link

Update handling of cache_control changed in nginx 1.23.0 (Fixes #96) #97

Closed hnakamur closed 2 years ago

hnakamur commented 2 years ago

This pull request fixes Nginx 1.23.0 header changes · Issue #96 · openresty/srcache-nginx-module. See https://github.com/nginx/nginx/commit/3aef1d693f3cc431563a7e6a6aba6a34e52 for changes in nginx.

zhuizhuhaomeng commented 2 years ago

@hnakamur you can add v1.23.0 to .travis.yml.

hnakamur commented 2 years ago

Add patch for nginx 1.23.0 by hnakamur · Pull Request #24 · openresty/no-pool-nginx is needed to be merged for travis nginx 1.23.0 to be successful.

zhuizhuhaomeng commented 2 years ago

@hnakamur no-pool-nginx.patch has been merged.

zhuizhuhaomeng commented 2 years ago

@hnakamur would you please retrigger the travis?

hnakamur commented 2 years ago

@zhuizhuhaomeng I tried to retrigger the travis, but the "Trigger build" menu in "More options" dropdown at https://app.travis-ci.com/github/openresty/srcache-nginx-module/jobs/574418725 is disabled. Would you regtrigger the travis instead?

zhuizhuhaomeng commented 2 years ago

I can not retrigger the travis also. I think you need to add a new commit , eg: add one space in the travis.yml.

zhuizhuhaomeng commented 2 years ago

@zhuizhuhaomeng I tried to retrigger the travis, but the "Trigger build" menu in "More options" dropdown at https://app.travis-ci.com/github/openresty/srcache-nginx-module/jobs/574418725 is disabled. Would you regtrigger the travis instead?

thanks god, I can retrigger the travis after I login travis-ci.com

zhuizhuhaomeng commented 2 years ago

Hi @hnakamur thanks your contribution. I have approved this PR. Because the following three modules are still not compatible with nginx-1.23.0 and the ci can not work properly, So I will not merge the PR for now.

lua-nginx-module
headers-more-nginx-module 
ngx_http_redis
hnakamur commented 2 years ago

Thanks for reviewing and approving!

zhuizhuhaomeng commented 2 years ago

@hnakamur t/private.t run failed. function ngx_http_srcache_process_multi_header_lines still think the r->headers_out.headers is an array. would you please fix it.

zhuizhuhaomeng commented 2 years ago

@hnakamur thank you for your contribution. I have merged the PR. The ci still can not pass due to other issues. We need other PRs to fix the ci.