openrewrite / rewrite-github-actions

OpenRewrite recipes for performing GitHub action hygiene and migration tasks.
Apache License 2.0
9 stars 10 forks source link

Prefer `Eclipse Temurin` when the build is in shared runners #43

Closed yeikel closed 1 year ago

yeikel commented 1 year ago

See https://github.com/actions/setup-java/blob/main/docs/advanced-usage.md#hosted-tool-cache

Also https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

- uses: actions/setup-java@v3.9.0
        with:
          distribution: zulu
          java-version: 17
- uses: actions/setup-java@v3.9.0
        with:
          distribution: temurin
          java-version: 17
sambsnyd commented 1 year ago

I've merged https://github.com/openrewrite/gh-automation/pull/32 Thanks for the suggestion, @yeikel , I did not know that github runners privileged temurin in this way

yeikel commented 1 year ago

I've merged https://github.com/openrewrite/gh-automation/pull/32 Thanks for the suggestion, @yeikel , I did not know that github runners privileged temurin in this way

No worries. I also discovered this recently

I opened this issue here so that we can create a recipe for it. It's likely a yml-only recipe when some of the other pending recipes are merged

yeikel commented 1 year ago

@timtebeek @sambsnyd Can you consider re-opening this? It does not seem that I have permissions to do so

yeikel commented 1 year ago

@timtebeek Can you assign this to me?

timtebeek commented 1 year ago

Sure! Much appreciated!