openrewrite / rewrite

Automated mass refactoring of source code.
https://docs.openrewrite.org
Apache License 2.0
2.09k stars 312 forks source link

Update rewrite-maven okhttp dependency to 5.x when 5.0.0 is released #1481

Closed pway99 closed 1 month ago

pway99 commented 2 years ago

okhttp is pinned to 4.9.3 per: #1479

https://mvnrepository.com/artifact/com.squareup.okhttp3/okhttp

Update to 5.x once 5.0.0 is released

timtebeek commented 12 months ago

We actually have some recipes now to automate this migration: https://docs.openrewrite.org/recipes/okhttp/upgradeokhttp5 Would be good to see how what automated migration pans out, and if that requires any additional cases to be covered.

AdityaKompalli commented 1 month ago

Hi, this is my first time contributing to open-source. Wanted to know if I can pick this up.

timtebeek commented 1 month ago

hi @AdityaKompalli ; thanks for the offer to help! It looks like there's still only alpha versions available of okhttp: https://square.github.io/okhttp/changelogs/changelog/ We're working towards automated migration recipes to v5 in https://github.com/openrewrite/rewrite-okhttp. If you'd like to help out with those migration recipes then you're most than welcome to chime in there!

The rewrite-maven module here we'll likely only update if a v5 of okhttp becomes available, which could be a while still. I think it makes sense to for now close this issue as it's not actionable yet, and instead revisit once 5.0 is out.