search

openrightsgroup / Blocking-Middleware

The censorship monitoring project (blocked.org.uk) API, database and message-queueing system
https://www.blocked.org.uk/
GNU General Public License v3.0
25 stars 11 forks source link

"Review Categories" tab won't mark green check when updated #118

Closed Mike-ORG closed 3 years ago

Mike-ORG commented 3 years ago

This has happened a couple times, where the addition or subtraction of categories works fine but no green check on the "Review Categories" tab appears after update.

Here is an example: https://www.blocked.org.uk/control/ispreports/Vodafone/http://www.thisisarecording.com?tab=categories

dantheta commented 3 years ago

The green tick function relates to ORG categories only - assigning categorify or DMOZ categories doesn't satisfy the conditions as they are currently written, though I can change them if required. One thing to keep in mind - if categorify categories are assigned, they might become unassigned if categorify change their criteria.

dantheta commented 3 years ago

I can switch the manually assigned categorify categories to their ORG counterparts, but I probably wouldn't be able to get to it until the weekend.

JimKillock commented 3 years ago

I think it makes sense for us to require an ORG category is assigned, does that make sense to you @Mike-ORG ?

Mike-ORG commented 3 years ago

Sure that makes sense, I will update the guidance and inform the volunteers.