search

openscopeproject / TrguiNG

Remote GUI for Transmission torrent daemon
GNU Affero General Public License v3.0
372 stars 47 forks source link

Transfers/Files/Peers that aren't completely finished round up to 100% #40

Closed melyux closed 1 year ago

melyux commented 1 year ago

When any percentage shown isn't quite 100%, it should stay at 99.9% to indicate that it's not quite done yet.

And hear me out here... what if 100% progress bars turn green?

qu1ck commented 1 year ago

Rounding fixed. More color: I heard you... answer is still no :D The status icon changes color and it is visually noticeable if you look for it while being subtle enough.

melyux commented 1 year ago

Fair enough, it will live in my private patches ;)

image
melyux commented 1 year ago

Even after the change, I saw today a torrent that had only 1 piece missing show up as 100% even though its status and everything else indicated that it was still Downloading.

qu1ck commented 1 year ago

Whatever percentage transmission reports I round down. If it reports 100% then it will be 100. Also it's possible you saw a missing piece in details panel but the table was more up to date. They are not always fully in sync because they work based on independent queries of transmission api.

qu1ck commented 1 year ago

Found one more place where rounding should be down, that probably fixes what you ran into.

Pentaphon commented 1 year ago

More color: I heard you... answer is still no :D The status icon changes color and it is visually noticeable if you look for it while being subtle enough.

Actually, there is discussion in the Tranmission issues page that is leaning towards my suggestion of having all the Transmission clients follow the Mac client in using the following color scheme for the progress bar and progress has already been made on the Web UI and GTK client https://github.com/transmission/transmission/issues/5648 so if you ever wanted to do what @melyux suggests, this might be a good reason to try some color changes.

qu1ck commented 1 year ago

Official transmission clients are very minimalistic and don't have any color. It works for that design. TrguiNG has a lot more color and already uses color for status, along with icons. I don't plan on changing progress bar colors but would welcome a PR if someone implements it as opt-in config option.

melyux commented 1 year ago

I'll submit my patch as a PR, just gotta figure out the setting thing

Pentaphon commented 1 year ago

Official transmission clients are very minimalistic and don't have any color. It works for that design.

Looks like its going to change for 4.1.0 or later because the Mac progress bar colors are going into the Qt, GTK and Web client which a lot of people seem to like, I think it works on the official clients because the progressbar is so big on Transmission compared to other clients so it acts as a very big visual indicator. I do see how it wouldn't work as well on TrguiNG because the UI and progressbar are more of a traditional uTorrent-like design.

I don't plan on changing progress bar colors but would welcome a PR if someone implements it as opt-in config option.

This is a welcome choice! Thanks!

I'll submit my patch as a PR, just gotta figure out the setting thing

Thanks! I was about to suggest that. I'm sure @qu1ck can help you figure that out.

Fair enough, it will live in my private patches ;)

@melyux do you have any other colors like red for error? red and pink alternating candy cane pattern for magnetizing status? (same as the light blue and blue alternating candy cane pattern for downloading status)

screenshot_apple_light

The Transmission Mac client does this for the most part but it needs more colors and hopefully all the clients will use unique colors for each status by 4.1.0 or a later version.

The GTK client is getting the Mac colors here: https://github.com/transmission/transmission/pull/5763 The official Web client is getting the Mac colors here: https://github.com/transmission/transmission/pull/5762 Qt is delayed a bit because the guy working on it needs help implementing it.

qu1ck commented 1 year ago

I'll submit my patch as a PR, just gotta figure out the setting thing

All you have to do is modify config.ts in 2 places (interface, default setting) and interfacepanel.tsx to modify the value. Make sure the fields in config and in form have same name and it should just work.

melyux commented 1 year ago

I have the first draft finished and operational. Testing it on my own for as many combinations as possible before opening PR