opensearch-project / dashboards-maps

:globe_with_meridians: User interface for the backend geospatial plugin which can be integrated with OpenSearch Dashboards and a home for all other map related features.
https://opensearch.org/docs/latest/dashboards/geojson-regionmaps/#custom-vector-maps-with-geojson
Apache License 2.0
17 stars 44 forks source link

Update data layer source name #588

Closed junqiu-lei closed 6 months ago

junqiu-lei commented 6 months ago

Description

Update layer source name from Data source to Index pattern followed from https://github.com/opensearch-project/dashboards-maps/issues/584#issuecomment-1953280806

Issues Resolved

https://github.com/opensearch-project/dashboards-maps/issues/584

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

junqiu-lei commented 6 months ago

Unrelated test failure due to OSD issue https://github.com/opensearch-project/OpenSearch-Dashboards/issues/5561#issuecomment-1952780312, adding --single-version=loose to resolve dependencies conflict.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.36%. Comparing base (811e8b0) to head (1b41da4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #588 +/- ## ======================================= Coverage 41.36% 41.36% ======================================= Files 53 53 Lines 1789 1789 Branches 328 328 ======================================= Hits 740 740 Misses 1019 1019 Partials 30 30 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

junqiu-lei commented 6 months ago

One cypress test failed on CI but passed at my local, cut issue separately https://github.com/opensearch-project/dashboards-maps/issues/592

  Documents layer

We detected that the Electron Renderer process just crashed.

We have failed the current spec but will continue running the next spec.

This can happen for a number of different reasons.

If you're running lots of tests on a memory intense application.
  - Try increasing the CPU/memory on the machine you're running on.
  - Try enabling experimentalMemoryManagement in your config file.
  - Try lowering numTestsKeptInMemory in your config file during 'cypress open'.

You can learn more here:

https://on.cypress.io/renderer-process-crashed

  (Results)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        2                                                                                │
  │ Passing:      0                                                                                │
  │ Failing:      1                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      1                                                                                │
  │ Screenshots:  0                                                                                │
  │ Video:        true                                                                             │
  │ Duration:     1 minute, 18 seconds                                                             │
  │ Spec Ran:     documentsLayer.cy.js                                                             │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
VijayanB commented 6 months ago

@junqiu-lei Do we need change in documentation website too? i remember sharing screenshot with select data source.

junqiu-lei commented 6 months ago

@junqiu-lei Do we need change in documentation website too? i remember sharing screenshot with select data source.

Sure, will raise PR to document repo if change needed.