opensearch-project / dashboards-maps

:globe_with_meridians: User interface for the backend geospatial plugin which can be integrated with OpenSearch Dashboards and a home for all other map related features.
https://opensearch.org/docs/latest/dashboards/geojson-regionmaps/#custom-vector-maps-with-geojson
Apache License 2.0
17 stars 44 forks source link

Add workflow to verify binary installation #591

Closed derek-ho closed 4 months ago

derek-ho commented 6 months ago

Description

I have observed some issues within other plugins of issues being only caught at run time. This is because several things can go wrong during the build process, which may not be caught in a dev setup. This adds a workflow to verify that building and installing into OSD works on every PR.

Related issues: https://github.com/opensearch-project/security-dashboards-plugin/issues/1709 https://github.com/opensearch-project/security-analytics-dashboards-plugin/pull/875 https://github.com/opensearch-project/dashboards-observability/pull/309 https://github.com/opensearch-project/OpenSearch-Dashboards/issues/5952

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

derek-ho commented 6 months ago

Seems like there is an issue with a recent dependency OSD core added. Created a follow up issue: https://github.com/opensearch-project/OpenSearch-Dashboards/issues/5953. @ryanbogan can you follow up here and help take this PR to completion? Thanks!