search

opensearch-project / dashboards-maps

:globe_with_meridians: User interface for the backend geospatial plugin which can be integrated with OpenSearch Dashboards and a home for all other map related features.
https://opensearch.org/docs/latest/dashboards/geojson-regionmaps/#custom-vector-maps-with-geojson
Apache License 2.0
17 stars 44 forks source link

Fix zoom level type error in custom layer #605

Closed junqiu-lei closed 5 months ago

junqiu-lei commented 5 months ago

Description

Fix zoom level type error in custom layer.

Issues Resolved

Closes https://github.com/opensearch-project/dashboards-maps/issues/604

Test Demo

https://github.com/opensearch-project/dashboards-maps/assets/90288540/e2913b7f-17b1-4b53-af50-59ab38b7abcc

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 43.89%. Comparing base (4f413a7) to head (db9414f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #605 +/- ## ========================================== + Coverage 41.36% 43.89% +2.53% ========================================== Files 53 53 Lines 1789 1795 +6 Branches 330 331 +1 ========================================== + Hits 740 788 +48 + Misses 1019 968 -51 - Partials 30 39 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

junqiu-lei commented 5 months ago

Cypress test passed on my local, the failure on the CI is unrelated to the PR.

VijayanB commented 5 months ago

Can we add unit test? Please add screenshot / video on how you tested it. Thanks

junqiu-lei commented 5 months ago

Can we add unit test? Please add screenshot / video on how you tested it. Thanks

Sure

junqiu-lei commented 5 months ago

Can we add unit test? Please add screenshot / video on how you tested it. Thanks

Sure

@VijayanB Unit tests and test video added.

naveentatikonda commented 5 months ago

@junqiu-lei Are we not backporting this to 2.x ?

junqiu-lei commented 5 months ago

@junqiu-lei Are we not backporting this to 2.x ?

We need backport 2.x, added tag at the same time