opensearch-project / dashboards-observability

Visualize and explore your logs, traces and metrics data in OpenSearch Dashboards
https://opensearch.org/docs/latest/observability-plugin/index/
Apache License 2.0
14 stars 52 forks source link

feat: make createAssets API compatible with workspace #2101

Closed SuZhou-Joe closed 1 month ago

SuZhou-Joe commented 1 month ago

Description

/api/observability/gettingStarted/createAssets now does not support workspace because it is using static ids for the objects that will be created. This PR is to fix the issue by detecting if there is workspaceId in the request, if so, prepend the workspace id to the objects id and their references.

Issues Resolved

[List any issues this PR will resolve]

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

TackAdam commented 1 month ago

LGTM. Thank you